From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: [PATCH 0/2] revert changes to zcache_do_preload()
Date: Thu, 23 Aug 2012 10:33:09 -0500 [thread overview]
Message-ID: <1345735991-6995-1-git-send-email-sjenning@linux.vnet.ibm.com> (raw)
This patchset fixes a regression in 3.6 by reverting two dependent
commits that made changes to zcache_do_preload().
The commits undermine an assumption made by tmem_put() in
the cleancache path that preemption is disabled. This change
introduces a race condition that can result in the wrong page
being returned by tmem_get(), causing assorted errors (segfaults,
apparent file corruption, etc) in userspace.
The corruption was discussed in this thread:
https://lkml.org/lkml/2012/8/17/494
Please apply this patchset to 3.6. This problem didn't exist
in previous releases so nothing need be done for the stable trees.
Seth Jennings (2):
Revert "staging: zcache: cleanup zcache_do_preload and
zcache_put_page"
Revert "staging: zcache: optimize zcache_do_preload"
drivers/staging/zcache/zcache-main.c | 54 +++++++++++++++++++---------------
1 file changed, 31 insertions(+), 23 deletions(-)
--
1.7.9.5
next reply other threads:[~2012-08-23 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 15:33 Seth Jennings [this message]
2012-08-23 15:33 ` [PATCH 1/2] Revert "staging: zcache: cleanup zcache_do_preload and zcache_put_page" Seth Jennings
2012-08-23 15:33 ` [PATCH 2/2] Revert "staging: zcache: optimize zcache_do_preload" Seth Jennings
2012-08-23 20:56 ` [PATCH 0/2] revert changes to zcache_do_preload() Minchan Kim
2012-08-23 22:10 ` Seth Jennings
2012-08-23 23:28 ` Minchan Kim
2012-08-24 2:21 ` Xiao Guangrong
2012-08-24 20:57 ` Seth Jennings
2012-08-29 17:42 ` Seth Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345735991-6995-1-git-send-email-sjenning@linux.vnet.ibm.com \
--to=sjenning@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).