From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: ananth@in.ibm.com, ppcdev <linuxppc-dev@lists.ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
peterz@infradead.org, oleg@redhat.com,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v4 2/2] powerpc: Uprobes port to powerpc
Date: Fri, 24 Aug 2012 17:07:31 +1000 [thread overview]
Message-ID: <1345792051.29170.25.camel@pasglop> (raw)
In-Reply-To: <1345770803.13865.10.camel@concordia>
On Fri, 2012-08-24 at 11:13 +1000, Michael Ellerman wrote:
>
> Yeah. A NULL regs here is a kernel bug, so I think it's actually
> preferable to crash than silently return.
Or best, if you think there's a remote chance that the bug might hit:
if (WARN(!regs))
return
Cheers,
Ben.
next prev parent reply other threads:[~2012-08-24 7:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 8:22 [PATCH 1/2] powerpc: Add trap_nr to thread_struct Ananth N Mavinakayanahalli
2012-08-22 8:27 ` [PATCH v4 2/2] powerpc: Uprobes port to powerpc Ananth N Mavinakayanahalli
2012-08-22 15:55 ` Oleg Nesterov
2012-08-23 4:28 ` Michael Ellerman
2012-08-23 5:32 ` Srikar Dronamraju
2012-08-23 10:06 ` Benjamin Herrenschmidt
2012-08-23 9:02 ` Oleg Nesterov
2012-08-23 16:02 ` Srikar Dronamraju
2012-08-23 16:17 ` Srikar Dronamraju
2012-08-23 21:57 ` Benjamin Herrenschmidt
2012-08-24 1:33 ` Michael Ellerman
2012-08-23 5:58 ` Ananth N Mavinakayanahalli
2012-08-24 1:13 ` Michael Ellerman
2012-08-24 7:07 ` Benjamin Herrenschmidt [this message]
2012-08-24 7:37 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345792051.29170.25.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=ananth@in.ibm.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).