From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@amd64.org>
Cc: Lin Ming <minggr@gmail.com>, Len Brown <lenb@kernel.org>,
Aaron Lu <aaron.lu@amd.com>,
linux-kernel@vger.kernel.org, Aaron Lu <aaron.lwe@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found
Date: Fri, 24 Aug 2012 15:36:21 -0700 [thread overview]
Message-ID: <1345847781.32359.15.camel@joe2Laptop> (raw)
In-Reply-To: <20120823132646.GD18279@aftab.osrc.amd.com>
On Thu, 2012-08-23 at 15:26 +0200, Borislav Petkov wrote:
> On Fri, Aug 10, 2012 at 10:05:53AM +0800, Aaron Lu wrote:
> > commit a606dac368eed5696fb38e16b1394f1d049c09e9 adds support to link
> > devices which have _PRx, if a device does not have _PRx, a warning
> > message will be printed.
> >
> > This commit is for ZPODD on Intel's platform, on AMD's platform, there
> > is no _PRx to support ZPODD, we use _PSx.
> >
> > So instead of printing a useless warning message on AMD's platform,
> > changing the print level to DEBUG to suppress this message.
[]
> > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
[]
> > @@ -460,7 +460,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
> > return ret;
> >
> > no_power_resource:
> > - printk(KERN_WARNING PREFIX "Invalid Power Resource to register!");
> > + printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
Perhaps add something like:
if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
printk(etc...)
instead?
next prev parent reply other threads:[~2012-08-24 22:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 2:05 [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found Aaron Lu
2012-08-23 13:26 ` Borislav Petkov
2012-08-24 22:36 ` Joe Perches [this message]
2012-08-29 2:01 ` Aaron Lu
2012-09-13 13:48 ` Borislav Petkov
2012-09-13 21:17 ` Rafael J. Wysocki
2012-09-13 22:10 ` Borislav Petkov
2012-09-13 22:27 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345847781.32359.15.camel@joe2Laptop \
--to=joe@perches.com \
--cc=aaron.lu@amd.com \
--cc=aaron.lwe@gmail.com \
--cc=bp@amd64.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minggr@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).