From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [PATCH 6/7] workqueue: init 0 for idle_rebind.cnt
Date: Tue, 28 Aug 2012 01:58:26 +0800 [thread overview]
Message-ID: <1346090307-3020-7-git-send-email-laijs@cn.fujitsu.com> (raw)
In-Reply-To: <1346090307-3020-1-git-send-email-laijs@cn.fujitsu.com>
Access idle_rebind.cnt is always protected by gcwq->lock,
don't need to init it as 1.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
kernel/workqueue.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index ed23c9a..9f38a65 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1394,7 +1394,7 @@ static void rebind_workers(struct global_cwq *gcwq)
* us to finish up by competing on pool->manager_mutex.
*/
init_completion(&idle_rebind.done);
- idle_rebind.cnt = 1;
+ idle_rebind.cnt = 0;
INIT_COMPLETION(idle_rebind.done);
/* set REBIND and kick idle ones, we'll wait for these later */
@@ -1435,7 +1435,7 @@ static void rebind_workers(struct global_cwq *gcwq)
}
/* waiting for all idle workers to be rebound */
- if (--idle_rebind.cnt) {
+ if (idle_rebind.cnt) {
spin_unlock_irq(&gcwq->lock);
wait_for_completion(&idle_rebind.done);
spin_lock_irq(&gcwq->lock);
--
1.7.4.4
next prev parent reply other threads:[~2012-08-27 17:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 17:58 [PATCH 0/7] workqueue: cleanup rebind_workers() Lai Jiangshan
2012-08-27 17:58 ` [PATCH 1/7] workqueue: wait on manager_mutex instead of rebind_hold Lai Jiangshan
2012-08-27 18:53 ` Tejun Heo
2012-08-27 17:58 ` [PATCH 2/7] workqueue: simple clear WORKER_REBIND Lai Jiangshan
2012-08-27 17:58 ` [PATCH 3/7] workqueue: explicit way to wait for idles workers to finish Lai Jiangshan
2012-08-27 17:58 ` [PATCH 4/7] workqueue: single pass rebind_workers Lai Jiangshan
2012-08-27 19:04 ` Tejun Heo
2012-08-29 2:21 ` Lai Jiangshan
2012-08-27 17:58 ` [PATCH 5/7] workqueue: ensure the wq_worker_sleeping() see the right flags Lai Jiangshan
2012-08-27 20:03 ` Tejun Heo
2012-08-27 17:58 ` Lai Jiangshan [this message]
2012-08-27 20:05 ` [PATCH 6/7] workqueue: init 0 for idle_rebind.cnt Tejun Heo
2012-08-28 4:36 ` Lai Jiangshan
2012-08-28 7:04 ` Tejun Heo
2012-08-27 17:58 ` [PATCH 7/7] workqueue: static idle_rebind Lai Jiangshan
2012-08-27 20:07 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346090307-3020-7-git-send-email-laijs@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).