From: Toshi Kani <toshi.kani@hp.com>
To: lenb@kernel.org, linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, joe@perches.com,
bhelgaas@google.com, isimatu.yasuaki@jp.fujitsu.com,
vijaymohan.pandarathil@hp.com, shaohua.li@intel.com,
Toshi Kani <toshi.kani@hp.com>
Subject: [PATCH v5 4/5] ACPI: Update Container hotplug error messages
Date: Tue, 28 Aug 2012 13:03:00 -0600 [thread overview]
Message-ID: <1346180581-12641-5-git-send-email-toshi.kani@hp.com> (raw)
In-Reply-To: <1346180581-12641-1-git-send-email-toshi.kani@hp.com>
Updated Container hotplug error messages with acpi_pr_<level>()
and pr_<level>(). Removed an unnecessary check to device pointer
in acpi_container_add().
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
---
drivers/acpi/container.c | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
index 1f9f7d7..519c1d6 100644
--- a/drivers/acpi/container.c
+++ b/drivers/acpi/container.c
@@ -97,12 +97,6 @@ static int acpi_container_add(struct acpi_device *device)
{
struct acpi_container *container;
-
- if (!device) {
- printk(KERN_ERR PREFIX "device is NULL\n");
- return -EINVAL;
- }
-
container = kzalloc(sizeof(struct acpi_container), GFP_KERNEL);
if (!container)
return -ENOMEM;
@@ -164,7 +158,7 @@ static void container_notify_cb(acpi_handle handle, u32 type, void *context)
case ACPI_NOTIFY_BUS_CHECK:
/* Fall through */
case ACPI_NOTIFY_DEVICE_CHECK:
- printk(KERN_WARNING "Container driver received %s event\n",
+ pr_debug("Container driver received %s event\n",
(type == ACPI_NOTIFY_BUS_CHECK) ?
"ACPI_NOTIFY_BUS_CHECK" : "ACPI_NOTIFY_DEVICE_CHECK");
@@ -185,7 +179,7 @@ static void container_notify_cb(acpi_handle handle, u32 type, void *context)
result = container_device_add(&device, handle);
if (result) {
- printk(KERN_WARNING "Failed to add container\n");
+ acpi_pr_warn(handle, "Failed to add container\n");
break;
}
--
1.7.7.6
next prev parent reply other threads:[~2012-08-28 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 19:02 [PATCH v5 0/5] ACPI: hotplug messages improvement Toshi Kani
2012-08-28 19:02 ` [PATCH v5 1/5] ACPI: Add acpi_pr_<level>() interfaces Toshi Kani
2012-08-28 19:02 ` [PATCH v5 2/5] ACPI: Update CPU hotplug error messages Toshi Kani
2012-08-28 19:02 ` [PATCH v5 3/5] ACPI: Update Memory " Toshi Kani
2012-08-28 19:03 ` Toshi Kani [this message]
2012-08-28 19:03 ` [PATCH v5 5/5] ACPI: Update Dock " Toshi Kani
2012-10-09 13:42 ` [PATCH v5 0/5] ACPI: hotplug messages improvement Toshi Kani
2012-10-11 15:22 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346180581-12641-5-git-send-email-toshi.kani@hp.com \
--to=toshi.kani@hp.com \
--cc=bhelgaas@google.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=vijaymohan.pandarathil@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).