* [PATCH 3.6-rc3] wlcore: Declare MODULE_FIRMWARE usage
@ 2012-08-29 14:48 Tim Gardner
2012-08-29 17:01 ` Luciano Coelho
0 siblings, 1 reply; 6+ messages in thread
From: Tim Gardner @ 2012-08-29 14:48 UTC (permalink / raw)
To: linux-kernel
Cc: Tim Gardner, Luciano Coelho, John W. Linville, Eliad Peller,
Arik Nemtsov, Eyal Shapira, linux-wireless, netdev
Cc: Luciano Coelho <coelho@ti.com>
Cc: "John W. Linville" <linville@tuxdriver.com>
Cc: Eliad Peller <eliad@wizery.com>
Cc: Arik Nemtsov <arik@wizery.com>
Cc: Eyal Shapira <eyal@wizery.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
drivers/net/wireless/ti/wlcore/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 7254860..a55ace6 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -5663,3 +5663,4 @@ MODULE_PARM_DESC(no_recovery, "Prevent HW recovery. FW will remain stuck.");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Luciano Coelho <coelho@ti.com>");
MODULE_AUTHOR("Juuso Oikarinen <juuso.oikarinen@nokia.com>");
+MODULE_FIRMWARE(WL12XX_NVS_NAME);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3.6-rc3] wlcore: Declare MODULE_FIRMWARE usage
2012-08-29 14:48 [PATCH 3.6-rc3] wlcore: Declare MODULE_FIRMWARE usage Tim Gardner
@ 2012-08-29 17:01 ` Luciano Coelho
2012-08-29 17:13 ` Tim Gardner
0 siblings, 1 reply; 6+ messages in thread
From: Luciano Coelho @ 2012-08-29 17:01 UTC (permalink / raw)
To: Tim Gardner
Cc: linux-kernel, John W. Linville, Eliad Peller, Arik Nemtsov,
Eyal Shapira, linux-wireless, netdev
On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote:
> Cc: Luciano Coelho <coelho@ti.com>
> Cc: "John W. Linville" <linville@tuxdriver.com>
> Cc: Eliad Peller <eliad@wizery.com>
> Cc: Arik Nemtsov <arik@wizery.com>
> Cc: Eyal Shapira <eyal@wizery.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
Please add a proper commit message. And there's no need to put all
these people in Cc: in the commit log. CC'ing when sending the patch is
enough (even though for such small patch, the linux-wireless mailing
list and myself is enough).
--
Luca.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.6-rc3] wlcore: Declare MODULE_FIRMWARE usage
2012-08-29 17:01 ` Luciano Coelho
@ 2012-08-29 17:13 ` Tim Gardner
2012-08-29 18:57 ` Luciano Coelho
0 siblings, 1 reply; 6+ messages in thread
From: Tim Gardner @ 2012-08-29 17:13 UTC (permalink / raw)
To: Luciano Coelho
Cc: linux-kernel, John W. Linville, Eliad Peller, Arik Nemtsov,
Eyal Shapira, linux-wireless, netdev
On 08/29/2012 11:01 AM, Luciano Coelho wrote:
> On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote:
>> Cc: Luciano Coelho <coelho@ti.com>
>> Cc: "John W. Linville" <linville@tuxdriver.com>
>> Cc: Eliad Peller <eliad@wizery.com>
>> Cc: Arik Nemtsov <arik@wizery.com>
>> Cc: Eyal Shapira <eyal@wizery.com>
>> Cc: linux-wireless@vger.kernel.org
>> Cc: netdev@vger.kernel.org
>> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
>> ---
>
> Please add a proper commit message. And there's no need to put all
> these people in Cc: in the commit log. CC'ing when sending the patch is
> enough (even though for such small patch, the linux-wireless mailing
> list and myself is enough).
>
> --
> Luca.
>
What more would you like covered in the commit message that isn't
obvious from the subject?
The Cc list comes from scripts/get_maintainers.pl as suggested by
Documentation/SubmittingPatches: "5) Select e-mail destination."
rtg
--
Tim Gardner tim.gardner@canonical.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.6-rc3] wlcore: Declare MODULE_FIRMWARE usage
2012-08-29 17:13 ` Tim Gardner
@ 2012-08-29 18:57 ` Luciano Coelho
2012-08-29 19:09 ` [PATCH 3.6-rc3 v2] " Tim Gardner
0 siblings, 1 reply; 6+ messages in thread
From: Luciano Coelho @ 2012-08-29 18:57 UTC (permalink / raw)
To: Tim Gardner
Cc: linux-kernel, John W. Linville, Eliad Peller, Arik Nemtsov,
Eyal Shapira, linux-wireless, netdev
On Wed, 2012-08-29 at 11:13 -0600, Tim Gardner wrote:
> On 08/29/2012 11:01 AM, Luciano Coelho wrote:
> > On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote:
> >> Cc: Luciano Coelho <coelho@ti.com>
> >> Cc: "John W. Linville" <linville@tuxdriver.com>
> >> Cc: Eliad Peller <eliad@wizery.com>
> >> Cc: Arik Nemtsov <arik@wizery.com>
> >> Cc: Eyal Shapira <eyal@wizery.com>
> >> Cc: linux-wireless@vger.kernel.org
> >> Cc: netdev@vger.kernel.org
> >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> >> ---
> >
> > Please add a proper commit message. And there's no need to put all
> > these people in Cc: in the commit log. CC'ing when sending the patch is
> > enough (even though for such small patch, the linux-wireless mailing
> > list and myself is enough).
> >
> > --
> > Luca.
> >
>
> What more would you like covered in the commit message that isn't
> obvious from the subject?
It's obvious from the subject, indeed. But commits with no descriptions
are ugly. Add something, for example a small "why" would be nice.
> The Cc list comes from scripts/get_maintainers.pl as suggested by
> Documentation/SubmittingPatches: "5) Select e-mail destination."
Yeah, that's correct, but it doesn't mean you should put them as Cc:
tags in the commit log. CCing when *sending* the email only is enough.
Most people won't really care for the entire lifetime of this patch.
And, come on, the Cc tags take more space than the actual patch.
--
Luca.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3.6-rc3 v2] wlcore: Declare MODULE_FIRMWARE usage
2012-08-29 18:57 ` Luciano Coelho
@ 2012-08-29 19:09 ` Tim Gardner
2012-09-28 8:49 ` Luciano Coelho
0 siblings, 1 reply; 6+ messages in thread
From: Tim Gardner @ 2012-08-29 19:09 UTC (permalink / raw)
To: linux-kernel; +Cc: Tim Gardner, Luciano Coelho, linux-wireless, netdev
Declare any firmware that might be used by this driver.
If all drivers declare their firmware usage, then a sufficiently
complete list of firmware files can then be used to pare down
the external linux-firmware package to just the files in actual use.
Cc: Luciano Coelho <coelho@ti.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
drivers/net/wireless/ti/wlcore/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 7254860..a55ace6 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -5663,3 +5663,4 @@ MODULE_PARM_DESC(no_recovery, "Prevent HW recovery. FW will remain stuck.");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Luciano Coelho <coelho@ti.com>");
MODULE_AUTHOR("Juuso Oikarinen <juuso.oikarinen@nokia.com>");
+MODULE_FIRMWARE(WL12XX_NVS_NAME);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3.6-rc3 v2] wlcore: Declare MODULE_FIRMWARE usage
2012-08-29 19:09 ` [PATCH 3.6-rc3 v2] " Tim Gardner
@ 2012-09-28 8:49 ` Luciano Coelho
0 siblings, 0 replies; 6+ messages in thread
From: Luciano Coelho @ 2012-09-28 8:49 UTC (permalink / raw)
To: Tim Gardner; +Cc: linux-kernel, linux-wireless, netdev
On Wed, 2012-08-29 at 13:09 -0600, Tim Gardner wrote:
> Declare any firmware that might be used by this driver.
> If all drivers declare their firmware usage, then a sufficiently
> complete list of firmware files can then be used to pare down
> the external linux-firmware package to just the files in actual use.
>
> Cc: Luciano Coelho <coelho@ti.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
Applied, thank you!
--
Luca.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-28 8:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-29 14:48 [PATCH 3.6-rc3] wlcore: Declare MODULE_FIRMWARE usage Tim Gardner
2012-08-29 17:01 ` Luciano Coelho
2012-08-29 17:13 ` Tim Gardner
2012-08-29 18:57 ` Luciano Coelho
2012-08-29 19:09 ` [PATCH 3.6-rc3 v2] " Tim Gardner
2012-09-28 8:49 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).