From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, shmulik.ladkani@gmail.com
Subject: Re: [PATCH 3/3] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs
Date: Thu, 30 Aug 2012 09:43:43 +0300 [thread overview]
Message-ID: <1346309023.2848.531.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1346001700-26895-3-git-send-email-shijie8@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]
On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote:
> This patch is based on the assumption that all the partitions are
> in the right offset order.
>
> Assume we have a 1GB(8Gb) nand chip, and we set the partitions
> in the command line like this:
> #gpmi-nand:100m(boot),100m(kernel),1g(rootfs)
>
> In this case, the partition truncating occurs. The current code will
> get the following result:
>
> ----------------------------------
> root@freescale ~$ cat /proc/mtd
> dev: size erasesize name
> mtd0: 06400000 00040000 "boot"
> mtd1: 06400000 00040000 "kernel"
> ----------------------------------
>
> It is obvious that we lost the truncated partition `rootfs` which should
> be 824M in this case.
>
> Why? The old code sets the wrong partitions number when the truncating
> occurs. This patch fixes it. Alao add a `break` to shortcut the code in this
> case.
>
> After apply this patch, the result becomes:
> ----------------------------------
> root@freescale ~$ cat /proc/mtd
> dev: size erasesize name
> mtd0: 06400000 00040000 "boot"
> mtd1: 06400000 00040000 "kernel"
> mtd2: 33800000 00040000 "rootfs"
> ----------------------------------
>
> We get the right result.
>
> Signed-off-by: Huang Shijie <shijie8@gmail.com>
Should this have CC to -stable?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-30 6:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 17:21 [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict Huang Shijie
2012-08-26 17:21 ` [PATCH 2/3] mtd: cmdlinepart: sort the unsorted partitions Huang Shijie
2012-08-31 13:59 ` Artem Bityutskiy
2012-08-31 14:29 ` Huang Shijie
2012-09-03 7:21 ` Artem Bityutskiy
2012-08-26 17:21 ` [PATCH 3/3] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs Huang Shijie
2012-08-30 6:43 ` Artem Bityutskiy [this message]
2012-08-30 6:39 ` Huang Shijie
2012-08-31 11:45 ` [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict Artem Bityutskiy
2012-08-31 13:36 ` Huang Shijie
2012-08-31 14:30 ` Huang Shijie
2012-09-03 7:18 ` Artem Bityutskiy
2012-09-03 15:09 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346309023.2848.531.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie8@gmail.com \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).