linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] video: mbxfb: Include linux/io.h instead of asm/io.h
@ 2012-08-31 13:39 Axel Lin
  2012-09-23 19:36 ` Florian Tobias Schandinat
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-08-31 13:39 UTC (permalink / raw)
  To: Florian Tobias Schandinat
  Cc: Arnd Bergmann, Mathieu Poirier, Damien Cassou, linux-fbdev, linux-kernel

This fixes below build error:

  CC [M]  drivers/video/mbx/mbxfb.o
drivers/video/mbx/mbxfb.c: In function 'mbxfb_probe':
drivers/video/mbx/mbxfb.c:942:2: error: implicit declaration of function 'devm_ioremap_nocache' [-Werror=implicit-function-declaration]
drivers/video/mbx/mbxfb.c:942:22: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/video/mbx/mbxfb.c:952:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/video/mbx/mbxfb.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c
index 9229acf..6563e50 100644
--- a/drivers/video/mbx/mbxfb.c
+++ b/drivers/video/mbx/mbxfb.c
@@ -26,8 +26,7 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/uaccess.h>
-
-#include <asm/io.h>
+#include <linux/io.h>
 
 #include <video/mbxfb.h>
 
-- 
1.7.9.5





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] video: mbxfb: Include linux/io.h instead of asm/io.h
  2012-08-31 13:39 [PATCH] video: mbxfb: Include linux/io.h instead of asm/io.h Axel Lin
@ 2012-09-23 19:36 ` Florian Tobias Schandinat
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Tobias Schandinat @ 2012-09-23 19:36 UTC (permalink / raw)
  To: Axel Lin
  Cc: Arnd Bergmann, Mathieu Poirier, Damien Cassou, linux-fbdev, linux-kernel

On 08/31/2012 01:39 PM, Axel Lin wrote:
> This fixes below build error:
> 
>   CC [M]  drivers/video/mbx/mbxfb.o
> drivers/video/mbx/mbxfb.c: In function 'mbxfb_probe':
> drivers/video/mbx/mbxfb.c:942:2: error: implicit declaration of function 'devm_ioremap_nocache' [-Werror=implicit-function-declaration]
> drivers/video/mbx/mbxfb.c:942:22: warning: assignment makes pointer from integer without a cast [enabled by default]
> drivers/video/mbx/mbxfb.c:952:21: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied. Thanks for pointing this out and fixing it.


Best regards,

Florian Tobias Schandinat

> ---
>  drivers/video/mbx/mbxfb.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c
> index 9229acf..6563e50 100644
> --- a/drivers/video/mbx/mbxfb.c
> +++ b/drivers/video/mbx/mbxfb.c
> @@ -26,8 +26,7 @@
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/uaccess.h>
> -
> -#include <asm/io.h>
> +#include <linux/io.h>
>  
>  #include <video/mbxfb.h>
>  


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-23 19:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-31 13:39 [PATCH] video: mbxfb: Include linux/io.h instead of asm/io.h Axel Lin
2012-09-23 19:36 ` Florian Tobias Schandinat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).