From: Joe Perches <joe@perches.com>
To: Cruz Julian Bishop <cruzjbishop@gmail.com>
Cc: mcgrof@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] scripts/checkincludes.pl: Simplify and shorten argument logic
Date: Fri, 31 Aug 2012 08:42:16 -0700 [thread overview]
Message-ID: <1346427736.31659.13.camel@joe2Laptop> (raw)
In-Reply-To: <1346419090-3808-3-git-send-email-cruzjbishop@gmail.com>
On Fri, 2012-08-31 at 23:18 +1000, Cruz Julian Bishop wrote:
> This patch allows for much easier implementation of arguments
> when modifying checkincludes.pl
>
> The variable $file is also initially named $arg - I wasn't sure
> if memory would be a problem (I know it would be in Java/C#) if
> another $file variable was initialized with the value of $arg,
> so I just left it.
>
> Overall, this still works nicely. There are some more
> potential simplifications, but I will cover those in another
> patch if I decide to implement them tonight.
perl argument processing is normally done via Getopt::Long.
http://perldoc.perl.org/Getopt/Long.html
next prev parent reply other threads:[~2012-08-31 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 13:18 [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 1/4] scripts/checkincludes.pl: Print usage with heredoc Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 2/4] scripts/checkincludes.pl: Simplify and shorten argument logic Cruz Julian Bishop
2012-08-31 15:42 ` Joe Perches [this message]
2012-08-31 21:54 ` Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 3/4] scripts/checkincludes.pl: Fix a bug introduced in the last commit Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 4/4] scripts/checkincludes.pl: Introduce 'quiet' mode Cruz Julian Bishop
2012-08-31 13:23 ` [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux Cruz Julian Bishop
2012-08-31 18:09 ` Jesper Juhl
2012-08-31 21:55 ` Cruz Julian Bishop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346427736.31659.13.camel@joe2Laptop \
--to=joe@perches.com \
--cc=cruzjbishop@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).