From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [PATCH 08/10 V4] workqueue: explicit way to wait for idles workers to finish
Date: Sun, 2 Sep 2012 00:28:26 +0800 [thread overview]
Message-ID: <1346516916-1991-9-git-send-email-laijs@cn.fujitsu.com> (raw)
In-Reply-To: <1346516916-1991-1-git-send-email-laijs@cn.fujitsu.com>
busy_worker_rebind_fn() can't return until all idle workers are rebound.
This order is ensured by rebind_workers() currently.
We use synchronize_all_idles_rebound() to wait for all idle workers
to be rebound. this is an explicit way and it will ease the pain of
the rebind_workers().
The sleeping synchronize_all_idles_rebound() must be called before
the WORKER_REBIND has been cleared.
It adds a small overhead to the unlikely path.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
kernel/workqueue.c | 16 +++++++++++++++-
1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index c875951..16bcd84 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1387,9 +1387,23 @@ static void busy_worker_rebind_fn(struct work_struct *work)
{
struct worker *worker = container_of(work, struct worker, rebind_work);
struct global_cwq *gcwq = worker->pool->gcwq;
+ struct idle_rebind *idle_rebind;
+
+ if (worker_maybe_bind_and_lock(worker)) {
+ /* Is idle-rebinding still in progress? */
+ if ((idle_rebind = gcwq->idle_rebind) != NULL) {
+ /* get reference */
+ BUG_ON(idle_rebind->ref_cnt <= 0);
+ idle_rebind->ref_cnt++;
+ spin_unlock_irq(&gcwq->lock);
+
+ synchronize_all_idles_rebound(gcwq, idle_rebind);
+
+ spin_lock_irq(&gcwq->lock);
+ }
- if (worker_maybe_bind_and_lock(worker))
worker_clr_flags(worker, WORKER_REBIND);
+ }
spin_unlock_irq(&gcwq->lock);
}
--
1.7.4.4
next prev parent reply other threads:[~2012-09-01 17:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 16:28 [PATCH 00/10 V4] workqueue: fix and cleanup hotplug/rebind_workers() Lai Jiangshan
2012-09-01 16:28 ` [PATCH 01/10 V4] workqueue: ensure the wq_worker_sleeping() see the right flags Lai Jiangshan
2012-09-04 23:39 ` [PATCH] workqueue: UNBOUND -> REBIND morphing in rebind_workers() should be atomic Tejun Heo
2012-09-04 23:58 ` [PATCH -stable] " Tejun Heo
2012-09-16 15:49 ` Ben Hutchings
2012-09-05 1:05 ` [PATCH] " Lai Jiangshan
2012-09-05 1:17 ` Tejun Heo
2012-09-01 16:28 ` [PATCH 02/10 V4] workqueue: fix deadlock in rebind_workers() Lai Jiangshan
2012-09-05 0:54 ` Tejun Heo
2012-09-05 1:28 ` Lai Jiangshan
2012-09-05 1:33 ` Tejun Heo
2012-09-01 16:28 ` [PATCH 03/10 V4] workqueue: add POOL_MANAGING_WORKERS Lai Jiangshan
2012-09-01 16:28 ` [PATCH 04/10 V4] workqueue: add manage_workers_slowpath() Lai Jiangshan
2012-09-05 1:12 ` Tejun Heo
2012-09-06 1:55 ` Lai Jiangshan
2012-09-01 16:28 ` [PATCH 05/10 V4] workqueue: move rebind_hold to idle_rebind Lai Jiangshan
2012-09-01 16:28 ` [PATCH 06/10 V4] workqueue: simple clear WORKER_REBIND Lai Jiangshan
2012-09-01 16:28 ` [PATCH 07/10 V4] workqueue: move idle_rebind pointer to gcwq Lai Jiangshan
2012-09-01 16:28 ` Lai Jiangshan [this message]
2012-09-01 16:28 ` [PATCH 09/10] workqueue: single pass rebind_workers Lai Jiangshan
2012-09-01 16:28 ` [PATCH 10/10 V4] workqueue: merge the role of rebind_hold to idle_done Lai Jiangshan
2012-09-05 1:15 ` Tejun Heo
2012-09-05 1:48 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346516916-1991-9-git-send-email-laijs@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).