From: Feng Tang <feng.tang@intel.com>
To: acme@redhat.com
Cc: mingo@elte.hu, a.p.zijlstra@chello.nl, andi@firstfloor.org,
namhyung@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org, Feng Tang <feng.tang@intel.com>
Subject: [PATCH 6/7] perf ui/browser: Integrate script browser into annotation browser
Date: Mon, 3 Sep 2012 16:14:32 +0800 [thread overview]
Message-ID: <1346660073-20279-7-git-send-email-feng.tang@intel.com> (raw)
In-Reply-To: <1346660073-20279-1-git-send-email-feng.tang@intel.com>
Integrate the script browser into annotation, users can press function
key 'r' to list all perf scripts and select one of them to run that
script, the output will be shown in a separate browser.
Signed-off-by: Feng Tang <feng.tang@intel.com>
---
tools/perf/ui/browsers/annotate.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index 67a2703..29a273a 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -11,6 +11,8 @@
#include <pthread.h>
#include <newt.h>
+#include "scripts.h"
+
struct browser_disasm_line {
struct rb_node rb_node;
double percent;
@@ -675,8 +677,14 @@ static int annotate_browser__run(struct annotate_browser *browser, int evidx,
"o Toggle disassembler output/simplified view\n"
"s Toggle source code view\n"
"/ Search string\n"
+ "r Run available scripts\n"
"? Search previous string\n");
continue;
+ case 'r':
+ {
+ script_browse(NULL);
+ continue;
+ }
case 'H':
nd = browser->curr_hot;
break;
--
1.7.1
next prev parent reply other threads:[~2012-09-03 8:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 8:14 [PATCH 0/7] perf ui/browser: Add browser for perf script Feng Tang
2012-09-03 8:14 ` [PATCH 1/7] perf symbols: Filter samples with unresolved symbol when "--symbols" option is used Feng Tang
2012-09-03 8:14 ` [PATCH 2/7] perf scripts: Add --symbols option to handle specific symbols Feng Tang
2012-09-03 8:14 ` [PATCH 3/7] perf scripts: Add event_analyzing_sample-record/report Feng Tang
2012-09-03 8:14 ` [PATCH 4/7] perf scripts: Export a find_scripts() function Feng Tang
2012-09-04 1:09 ` Namhyung Kim
2012-09-04 1:34 ` Namhyung Kim
2012-09-03 8:14 ` [PATCH 5/7] perf ui/browser: Add a browser for perf script Feng Tang
2012-09-04 1:57 ` Namhyung Kim
2012-09-04 9:13 ` Feng Tang
2012-09-05 0:33 ` Namhyung Kim
2012-09-03 8:14 ` Feng Tang [this message]
2012-09-03 8:14 ` [PATCH 7/7] perf ui/browser: Integrate script browser into main hists browser Feng Tang
2012-09-04 0:50 ` [PATCH 0/7] perf ui/browser: Add browser for perf script Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346660073-20279-7-git-send-email-feng.tang@intel.com \
--to=feng.tang@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).