linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Luebbe <jlu@pengutronix.de>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: linux-kernel@vger.kernel.org, Jan Luebbe <jlu@pengutronix.de>
Subject: [PATCH] lib/dma-debug: check for vmalloc buffers used with the DMA-API
Date: Mon,  3 Sep 2012 13:00:04 +0200	[thread overview]
Message-ID: <1346670004-10248-1-git-send-email-jlu@pengutronix.de> (raw)

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
I'm not sure why we don't check for high memory, is there any problem
with this approach?

 lib/dma-debug.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 66ce414..7d60ff0 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -944,6 +944,9 @@ static void check_for_illegal_area(struct device *dev, void *addr, unsigned long
 	if (overlap(addr, len, _text, _etext) ||
 	    overlap(addr, len, __start_rodata, __end_rodata))
 		err_printk(dev, NULL, "DMA-API: device driver maps memory from kernel text or rodata [addr=%p] [len=%lu]\n", addr, len);
+	if (is_vmalloc_or_module_addr(addr) ||
+	    is_vmalloc_or_module_addr(addr+len))
+		err_printk(dev, NULL, "DMA-API: device driver maps memory from vmalloc or module address range [addr=%p] [len=%lu]\n", addr, len);
 }
 
 static void check_sync(struct device *dev,
-- 
1.7.10.4


             reply	other threads:[~2012-09-03 11:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03 11:00 Jan Luebbe [this message]
2012-09-18 13:18 ` Joerg Roedel
2012-09-19 15:28   ` [PATCH v2] lib/dma-debug: check for vmalloc and module addresses " Jan Luebbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346670004-10248-1-git-send-email-jlu@pengutronix.de \
    --to=jlu@pengutronix.de \
    --cc=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] lib/dma-debug: check for vmalloc buffers used with the DMA-API' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).