From: Glauber Costa <glommer@parallels.com>
To: <linux-kernel@vger.kernel.org>
Cc: <cgroups@vger.kernel.org>, <linux-mm@kvack.org>,
davej@redhat.com, ben@decadent.org.uk, a.p.zijlstra@chello.nl,
pjt@google.com, lennart@poettering.net, kay.sievers@vrfy.org,
tj@kernel.org, Glauber Costa <glommer@parallels.com>
Subject: [RFC 5/5] sched: add cpusets to comounts list
Date: Tue, 4 Sep 2012 18:18:20 +0400 [thread overview]
Message-ID: <1346768300-10282-6-git-send-email-glommer@parallels.com> (raw)
In-Reply-To: <1346768300-10282-1-git-send-email-glommer@parallels.com>
Although we have not yet identified any place where cpusets could be
improved performance-wise by guaranteeing comounts with the other two
cpu cgroups, it is a sane choice to mount them together.
We can preemptively benefit from it and avoid a growing mess, by
guaranteeing that subsystems that mostly contraint the same kind of
resource will live together. With cgroups is never that simple, and
things crosses boundaries quite often. But I hope this can be seen as a
potential improvement.
Signed-off-by: Glauber Costa <glommer@parallels.com>
CC: Dave Jones <davej@redhat.com>
CC: Ben Hutchings <ben@decadent.org.uk>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Paul Turner <pjt@google.com>
CC: Lennart Poettering <lennart@poettering.net>
CC: Kay Sievers <kay.sievers@vrfy.org>
CC: Tejun Heo <tj@kernel.org>
---
kernel/cpuset.c | 4 ++++
kernel/sched/core.c | 8 ++++----
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 8c8bd65..f8e1c49 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1879,6 +1879,10 @@ struct cgroup_subsys cpuset_subsys = {
.post_clone = cpuset_post_clone,
.subsys_id = cpuset_subsys_id,
.base_cftypes = files,
+#ifdef CONFIG_CGROUP_FORCE_COMOUNT_CPU
+ .comounts = 2,
+ .must_comount = { cpu_cgroup_subsys_id, cpuacct_subsys_id, },
+#endif
.early_init = 1,
};
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index d654bd1..aeff02c 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8301,8 +8301,8 @@ struct cgroup_subsys cpu_cgroup_subsys = {
.subsys_id = cpu_cgroup_subsys_id,
.base_cftypes = cpu_files,
#ifdef CONFIG_CGROUP_FORCE_COMOUNT_CPU
- .comounts = 1,
- .must_comount = { cpuacct_subsys_id, },
+ .comounts = 2,
+ .must_comount = { cpuacct_subsys_id, cpuset_subsys_id, },
.bind = cpu_cgroup_bind,
#endif
.early_init = 1,
@@ -8637,8 +8637,8 @@ struct cgroup_subsys cpuacct_subsys = {
.base_cftypes = files,
.bind = cpuacct_bind,
#ifdef CONFIG_CGROUP_FORCE_COMOUNT_CPU
- .comounts = 1,
- .must_comount = { cpu_cgroup_subsys_id, },
+ .comounts = 2,
+ .must_comount = { cpu_cgroup_subsys_id, cpuset_subsys_id, },
#endif
};
#endif /* CONFIG_CGROUP_CPUACCT */
--
1.7.11.4
next prev parent reply other threads:[~2012-09-04 14:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 14:18 [RFC 0/5] forced comounts for cgroups Glauber Costa
2012-09-04 14:18 ` [RFC 1/5] cgroup: allow some comounts to be forced Glauber Costa
2012-09-04 14:18 ` [RFC 2/5] sched: adjust exec_clock to use it as cpu usage metric Glauber Costa
2012-09-04 14:18 ` [RFC 3/5] sched: do not call cpuacct_charge when cpu and cpuacct are comounted Glauber Costa
2012-09-04 14:18 ` [RFC 4/5] cpuacct: do not gather cpuacct statistics when not mounted Glauber Costa
2012-09-04 14:18 ` Glauber Costa [this message]
2012-09-04 21:46 ` [RFC 0/5] forced comounts for cgroups Tejun Heo
2012-09-05 8:03 ` Glauber Costa
2012-09-05 8:14 ` Tejun Heo
2012-09-05 8:17 ` Glauber Costa
2012-09-05 8:29 ` Tejun Heo
2012-09-05 8:35 ` Glauber Costa
2012-09-05 8:47 ` Tejun Heo
2012-09-05 8:55 ` Glauber Costa
2012-09-05 9:07 ` Tejun Heo
2012-09-05 9:06 ` Glauber Costa
2012-09-05 9:14 ` Tejun Heo
2012-09-05 9:06 ` Peter Zijlstra
2012-09-05 9:07 ` Peter Zijlstra
2012-09-05 9:22 ` Tejun Heo
2012-09-05 9:11 ` Tejun Heo
2012-09-05 9:12 ` Glauber Costa
2012-09-05 9:19 ` Tejun Heo
2012-09-05 9:30 ` Glauber Costa
2012-09-05 9:26 ` Peter Zijlstra
2012-09-05 9:31 ` Glauber Costa
2012-09-05 9:45 ` Tejun Heo
2012-09-05 9:48 ` Glauber Costa
2012-09-05 9:56 ` Tejun Heo
2012-09-05 10:20 ` Peter Zijlstra
2012-09-06 20:38 ` Tejun Heo
2012-09-06 22:39 ` Glauber Costa
2012-09-06 22:45 ` Tejun Heo
2012-09-05 9:32 ` Tejun Heo
2012-09-05 10:04 ` Peter Zijlstra
2012-09-06 20:46 ` Tejun Heo
2012-09-06 21:11 ` Paul Turner
2012-09-06 22:36 ` Glauber Costa
2012-09-08 13:36 ` Dhaval Giani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346768300-10282-6-git-send-email-glommer@parallels.com \
--to=glommer@parallels.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ben@decadent.org.uk \
--cc=cgroups@vger.kernel.org \
--cc=davej@redhat.com \
--cc=kay.sievers@vrfy.org \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pjt@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).