archive mirror
 help / color / mirror / Atom feed
From: Matt Fleming <>
To: Josh Triplett <>
	Thomas Gleixner <>,
	Ingo Molnar <>, "H. Peter Anvin" <>,, Len Brown <>,
	Olof Johansson <>, Matthew Garrett <>,
	David Howells <>,
	Rusty Russell <>,
	Jim Cromie <>,
	Peter Zijlstra <>,
	Pawel Moll <>,, linux-efi <>
Subject: Re: [PATCH 0/3] Fix ACPI BGRT support for images located in EFI boot services memory
Date: Tue, 04 Sep 2012 15:27:20 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 2012-08-30 at 14:28 -0700, Josh Triplett wrote:
> The ACPI BGRT lets the OS access the BIOS logo image and its position on the
> screen at boot time, allowing it to maintain that image on the screen until
> ready to display something else, making boot more seamless.  This series fixes
> support for accessing the boot logo image via the BGRT when the BIOS stores it
> in EFI boot services memory, as recommended by the ACPI 5.0 spec.  Linux needs
> to copy the image out of boot services memory before reclaiming boot services
> memory.
> The first patch refactors EFI initialization to defer freeing boot services
> memory until later in the boot process, after we have ACPI available.  The
> second patch adds a helper function to look up existing EFI boot services
> mappings, to avoid re-mapping them.  The third patch moves BGRT initialization
> to before the reclamation of boot services memory, copies the logo at that
> point, and reworks the existing BGRT driver to use that existing copy.

Since we always end up doing a copy anyway, is there no way we could
just copy the boot logo *without* deferring freeing the boot services
code, e.g. move the copy before we do SetVirtualAddressMap()? I wouldn't
be surprised if some implementations got really cranky if we accessed
boot services data after we installed a new virtual memory map.

Besides, if we can avoid moving the efi_free_boot_services() call we can
avoid littering init/main.c with more #ifdef CONFIG_X86 blocks.

  parent reply	other threads:[~2012-09-04 14:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 21:28 [PATCH 0/3] Fix ACPI BGRT support for images located in EFI boot services memory Josh Triplett
2012-08-30 21:28 ` [PATCH 1/3] efi: Defer freeing boot services memory until after ACPI init Josh Triplett
2012-08-30 21:28 ` [PATCH 2/3] efi: Add a function to look up existing IO memory mappings Josh Triplett
2012-08-30 21:28 ` [PATCH 3/3] efi: Fix the ACPI BGRT driver for images located in EFI boot services memory Josh Triplett
2012-09-04 14:27 ` Matt Fleming [this message]
2012-09-04 17:59   ` [PATCH 0/3] Fix ACPI BGRT support " Josh Triplett
2012-09-04 18:10     ` H. Peter Anvin
2012-09-04 19:45       ` Josh Triplett
2012-09-04 20:24         ` H. Peter Anvin
2012-09-04 20:29           ` Josh Triplett
2012-09-04 20:11     ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).