* [PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard coded 0x0ffbc0000
@ 2012-09-05 2:19 Axel Lin
2012-09-05 9:57 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-09-05 2:19 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Chris Schlund, linux-input, linux-kernel
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/hid/hid-lcpower.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-lcpower.c b/drivers/hid/hid-lcpower.c
index c4fe9bd0..22bc14a 100644
--- a/drivers/hid/hid-lcpower.c
+++ b/drivers/hid/hid-lcpower.c
@@ -24,7 +24,7 @@ static int ts_input_mapping(struct hid_device *hdev, struct hid_input *hi,
struct hid_field *field, struct hid_usage *usage,
unsigned long **bit, int *max)
{
- if ((usage->hid & HID_USAGE_PAGE) != 0x0ffbc0000)
+ if ((usage->hid & HID_USAGE_PAGE) != HID_UP_LOGIVENDOR)
return 0;
switch (usage->hid & HID_USAGE) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard coded 0x0ffbc0000
2012-09-05 2:19 [PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard coded 0x0ffbc0000 Axel Lin
@ 2012-09-05 9:57 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2012-09-05 9:57 UTC (permalink / raw)
To: Axel Lin; +Cc: Chris Schlund, linux-input, linux-kernel
On Wed, 5 Sep 2012, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/hid/hid-lcpower.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-lcpower.c b/drivers/hid/hid-lcpower.c
> index c4fe9bd0..22bc14a 100644
> --- a/drivers/hid/hid-lcpower.c
> +++ b/drivers/hid/hid-lcpower.c
> @@ -24,7 +24,7 @@ static int ts_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> struct hid_field *field, struct hid_usage *usage,
> unsigned long **bit, int *max)
> {
> - if ((usage->hid & HID_USAGE_PAGE) != 0x0ffbc0000)
> + if ((usage->hid & HID_USAGE_PAGE) != HID_UP_LOGIVENDOR)
> return 0;
>
> switch (usage->hid & HID_USAGE) {
The name of the actual constant is quite losing its point with more and
more non-Logitech devices using this usage page.
I am applying your patch now, but I guess we'll rather rename the define
in a near future.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-05 9:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-05 2:19 [PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard coded 0x0ffbc0000 Axel Lin
2012-09-05 9:57 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).