From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ming Lei <ming.lei@canonical.com>, Takashi Iwai <tiwai@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Kay Sievers <kay@vrfy.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: A workaround for request_firmware() stuck in module_init
Date: Thu, 06 Sep 2012 07:08:54 +1000 [thread overview]
Message-ID: <1346879334.19098.1.camel@pasglop> (raw)
In-Reply-To: <20120905173011.7a1111f0@pyramind.ukuu.org.uk>
On Wed, 2012-09-05 at 17:30 +0100, Alan Cox wrote:
>
> > Linus has said that he doesn't like to load firmware in probe(), but
> in some
> > situation the drivers have to load firmware in its probe():
>
> You don't want to load firmware in probe because of the locking
> problems
> - you can trigger a load of another device on the same bus - the defer
> dodges that nicely
But then you have cases where probe() -> register_with_my_subsystem() ->
open(). Network devices come to mind. IE. udev must be able to deal with
a synchronous firmware load from probe I'm afraid.
The only other option would be to make full operation of the driver
delayed even from open(), which is possible with network devices at
least but generally very complex to implement.
Cheers,
Ben.
next prev parent reply other threads:[~2012-09-05 21:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 13:06 A workaround for request_firmware() stuck in module_init Takashi Iwai
2012-09-04 15:52 ` Ming Lei
2012-09-04 16:10 ` Takashi Iwai
2012-09-05 1:15 ` Ming Lei
2012-09-05 5:53 ` Takashi Iwai
2012-09-05 11:32 ` Ming Lei
2012-09-05 13:03 ` Alan Cox
2012-09-05 14:01 ` Takashi Iwai
2012-09-05 15:22 ` Ming Lei
2012-09-05 16:30 ` Alan Cox
2012-09-05 21:08 ` Benjamin Herrenschmidt [this message]
2012-09-05 23:18 ` Alan Cox
2012-09-06 5:06 ` Benjamin Herrenschmidt
2012-09-06 2:47 ` Linus Torvalds
2012-09-06 4:12 ` Ming Lei
2012-09-06 12:59 ` Alan Cox
2012-09-06 15:38 ` Ming Lei
2012-09-05 16:59 ` Lucas De Marchi
2012-09-05 17:09 ` Takashi Iwai
2012-09-05 16:51 ` Lucas De Marchi
2012-09-05 17:08 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346879334.19098.1.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=rjw@sisk.pl \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).