From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 3.6 0/3] Fix use-after-free in PSCSI
Date: Wed, 05 Sep 2012 17:41:39 -0700 [thread overview]
Message-ID: <1346892099.4162.325.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <1346857755-10224-1-git-send-email-pbonzini@redhat.com>
On Wed, 2012-09-05 at 17:09 +0200, Paolo Bonzini wrote:
> Hi,
>
> this series fixes the bug I reported with wrong sense data. The
> memory corruption is caused by using the sense data after freeing
> it. The series corrects it by moving the copy of the sense data
> earlier, to the transport_complete callback.
>
> Please review and be kind on my first lio patches! :)
>
> Paolo
>
> Paolo Bonzini (3):
> target: move transport_get_sense_data
> target: simplify code around transport_get_sense_data
> target: fix use-after-free with PSCSI sense data
>
> drivers/target/target_core_pscsi.c | 21 ++----
> drivers/target/target_core_transport.c | 117 ++++++++++++--------------------
> include/target/target_core_backend.h | 4 +-
> 3 files changed, 53 insertions(+), 89 deletions(-)
>
The approach to squash the bug looks easonable to me, and nice work on
the extra cleanups for backend sense w/ TRANSPORT_PLUGIN_PHBA_PDEV !
I've applied this to target-pending/master w/ CC stable, and will plan
to send out the PULL request for -rc5 over the next days.
Nice work Paolo!
--nab
prev parent reply other threads:[~2012-09-06 0:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 15:09 [PATCH 3.6 0/3] Fix use-after-free in PSCSI Paolo Bonzini
2012-09-05 15:09 ` [PATCH 3.6 1/3] target: move transport_get_sense_data Paolo Bonzini
2012-09-05 15:09 ` [PATCH 3.6 2/3] target: simplify code around transport_get_sense_data Paolo Bonzini
2012-09-05 15:09 ` [PATCH 3.6 3/3] target: fix use-after-free with PSCSI sense data Paolo Bonzini
2012-09-06 0:41 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346892099.4162.325.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).