linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -mm] cciss: select CONFIG_CHECK_SIGNATURE
@ 2012-09-07 13:56 Akinobu Mita
  2012-09-07 14:29 ` scameron
  0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2012-09-07 13:56 UTC (permalink / raw)
  To: linux-kernel, akpm
  Cc: Akinobu Mita, Fengguang Wu, Mike Miller, Jens Axboe, Stephen M. Cameron

The patch cciss-use-check_signature.patch in -mm tree introduced
a build error:

drivers/built-in.o: In function `CISS_signature_present':
drivers/block/cciss.c:4270: undefined reference to `check_signature'

Add missing CONFIG_CHECK_SIGNATURE to fix this issue.

Reported-by: Fengguang Wu <wfg@linux.intel.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Fengguang Wu <wfg@linux.intel.com>
Cc: Mike Miller <mike.miller@hp.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
---
 drivers/block/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index f529407..f7de322 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -131,6 +131,7 @@ config BLK_CPQ_DA
 config BLK_CPQ_CISS_DA
 	tristate "Compaq Smart Array 5xxx support"
 	depends on PCI
+	select CHECK_SIGNATURE
 	help
 	  This is the driver for Compaq Smart Array 5xxx controllers.
 	  Everyone using these boards should say Y here.
-- 
1.7.11.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -mm] cciss: select CONFIG_CHECK_SIGNATURE
  2012-09-07 13:56 [PATCH -mm] cciss: select CONFIG_CHECK_SIGNATURE Akinobu Mita
@ 2012-09-07 14:29 ` scameron
  0 siblings, 0 replies; 2+ messages in thread
From: scameron @ 2012-09-07 14:29 UTC (permalink / raw)
  To: Akinobu Mita; +Cc: linux-kernel, akpm, Fengguang Wu, Mike Miller, Jens Axboe

On Fri, Sep 07, 2012 at 10:56:51PM +0900, Akinobu Mita wrote:
> The patch cciss-use-check_signature.patch in -mm tree introduced
> a build error:
> 
> drivers/built-in.o: In function `CISS_signature_present':
> drivers/block/cciss.c:4270: undefined reference to `check_signature'
> 
> Add missing CONFIG_CHECK_SIGNATURE to fix this issue.
> 

Ack.  

Same thing that was done for hpsa.

-- steve

> Reported-by: Fengguang Wu <wfg@linux.intel.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Fengguang Wu <wfg@linux.intel.com>
> Cc: Mike Miller <mike.miller@hp.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
> ---
>  drivers/block/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index f529407..f7de322 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -131,6 +131,7 @@ config BLK_CPQ_DA
>  config BLK_CPQ_CISS_DA
>  	tristate "Compaq Smart Array 5xxx support"
>  	depends on PCI
> +	select CHECK_SIGNATURE
>  	help
>  	  This is the driver for Compaq Smart Array 5xxx controllers.
>  	  Everyone using these boards should say Y here.
> -- 
> 1.7.11.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-07 14:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-07 13:56 [PATCH -mm] cciss: select CONFIG_CHECK_SIGNATURE Akinobu Mita
2012-09-07 14:29 ` scameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).