From: Suresh Siddha <suresh.b.siddha@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: mingo@kernel.org, torvalds@linux-foundation.org,
andreas.herrmann3@amd.com, bp@amd64.org, robert.richter@amd.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] x86, fpu: decouple non-lazy/eager fpu restore from xsave
Date: Fri, 07 Sep 2012 12:12:20 -0700 [thread overview]
Message-ID: <1347045140.26695.57.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <504A414E.40507@zytor.com>
On Fri, 2012-09-07 at 11:47 -0700, H. Peter Anvin wrote:
> On 09/07/2012 11:31 AM, Suresh Siddha wrote:
> >
> > +static inline void fx_finit(struct i387_fxsave_struct *fx)
> > +{
> > + memset(fx, 0, xstate_size);
> > + fx->cwd = 0x37f;
> > + if (cpu_has_xmm)
> > + fx->mxcsr = MXCSR_DEFAULT;
> > +}
> > +
>
> Incidentally, Al Viro asked a very good question the other day, which is
> why can't we just set mxcsr unconditionally here? I don't think any
> CPUs with FXSAVE and no MXCSR (Pentium II from Intel,
> Crusoe/TM-3xxx/5xxx from Transmeta, and presumably some of the K6
> generation from AMD) ever looked at this field.
Ok. We can do this as a separate patch.
thanks,
suresh
prev parent reply other threads:[~2012-09-07 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 18:31 [PATCH 1/3] x86, fpu: decouple non-lazy/eager fpu restore from xsave Suresh Siddha
2012-09-07 18:31 ` [PATCH 2/3] x86, fpu: enable eagerfpu by default for xsaveopt Suresh Siddha
2012-09-07 18:43 ` H. Peter Anvin
2012-09-07 19:20 ` Suresh Siddha
2012-09-07 18:31 ` [PATCH 3/3] x86, fpu: move check_fpu() after alternative_instructions() Suresh Siddha
2012-09-07 18:47 ` [PATCH 1/3] x86, fpu: decouple non-lazy/eager fpu restore from xsave H. Peter Anvin
2012-09-07 19:12 ` Suresh Siddha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347045140.26695.57.camel@sbsiddha-desk.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=andreas.herrmann3@amd.com \
--cc=bp@amd64.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=robert.richter@amd.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).