From: Davidlohr Bueso <dave@gnu.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] lib: gcd: prevent possible div by 0
Date: Mon, 10 Sep 2012 12:30:04 +0200 [thread overview]
Message-ID: <1347273004.2561.8.camel@offbook> (raw)
In-Reply-To: <1347268343.1234.1307.camel@edumazet-glaptop>
On Mon, 2012-09-10 at 11:12 +0200, Eric Dumazet wrote:
> On Sun, 2012-09-09 at 17:03 +0200, Davidlohr Bueso wrote:
> > Account for properties when a and/or b are 0:
> > gcd(0, 0) = 0
> > gcd(a, 0) = a
> > gcd(0, b) = b
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> > ---
> > lib/gcd.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/lib/gcd.c b/lib/gcd.c
> > index cce4f3c..7e163c6 100644
> > --- a/lib/gcd.c
> > +++ b/lib/gcd.c
> > @@ -7,6 +7,9 @@ unsigned long gcd(unsigned long a, unsigned long b)
> > {
> > unsigned long r;
> >
> > + if (!a || !b)
> > + return a | b;
>
> This seems overkill
It might, but it reads better, IMHO.
>
> > +
> > if (a < b)
> > swap(a, b);
>
> better here to :
> if (!b)
> return a;
>
Sure, I don't mind either way. I'll send a v2 shortly.
Thanks for reviewing.
Davidlohr
prev parent reply other threads:[~2012-09-10 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 15:03 [PATCH] lib: gcd: prevent possible div by 0 Davidlohr Bueso
2012-09-10 9:12 ` Eric Dumazet
2012-09-10 10:30 ` Davidlohr Bueso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347273004.2561.8.camel@offbook \
--to=dave@gnu.org \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).