From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: [PATCH v2 10/10] thp: implement refcounting for huge zero page
Date: Mon, 10 Sep 2012 16:57:59 +0200 [thread overview]
Message-ID: <1347289079.1234.1706.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120910144438.GA31697@otc-wbsnb-06>
On Mon, 2012-09-10 at 17:44 +0300, Kirill A. Shutemov wrote:
> Yes, disabling preemption before alloc_pages() and enabling after
> atomic_set() looks reasonable. Thanks.
In fact, as alloc_pages(GFP_TRANSHUGE | __GFP_ZERO, HPAGE_PMD_ORDER);
might sleep, it would be better to disable preemption after calling it :
zero_page = alloc_pages(GFP_TRANSHUGE | __GFP_ZERO, HPAGE_PMD_ORDER);
if (!zero_page)
return 0;
preempt_disable();
if (cmpxchg(&huge_zero_pfn, 0, page_to_pfn(zero_page))) {
preempt_enable();
__free_page(zero_page);
goto retry;
}
atomic_set(&huge_zero_refcount, 2);
preempt_enable();
next prev parent reply other threads:[~2012-09-10 14:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 13:13 [PATCH v2 00/10] Introduce huge zero page Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 01/10] thp: huge zero page: basic preparation Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 02/10] thp: zap_huge_pmd(): zap huge zero pmd Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 03/10] thp: copy_huge_pmd(): copy huge zero page Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 04/10] thp: do_huge_pmd_wp_page(): handle " Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 05/10] thp: change_huge_pmd(): keep huge zero page write-protected Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 06/10] thp: change split_huge_page_pmd() interface Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 07/10] thp: implement splitting pmd for huge zero page Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 08/10] thp: setup huge zero page on non-write page fault Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 09/10] thp: lazy huge zero page allocation Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 10/10] thp: implement refcounting for huge zero page Kirill A. Shutemov
2012-09-10 14:02 ` Eric Dumazet
2012-09-10 14:44 ` Kirill A. Shutemov
2012-09-10 14:48 ` Eric Dumazet
2012-09-10 14:50 ` Kirill A. Shutemov
2012-09-10 14:57 ` Eric Dumazet [this message]
2012-09-10 15:07 ` Kirill A. Shutemov
2012-09-12 10:07 ` [PATCH v3 " Kirill A. Shutemov
2012-09-13 17:16 ` Andrea Arcangeli
2012-09-13 17:37 ` Kirill A. Shutemov
2012-09-13 21:17 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347289079.1234.1706.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).