[PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree

* [PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree
@ 2012-09-12 15:06 Peter Senna Tschudin
  2012-09-12 16:19 ` Guenter Roeck
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Senna Tschudin @ 2012-09-12 15:06 UTC (permalink / raw)
  To: Luca Tettamanti
  Cc: kernel-janitors, Jean Delvare, Guenter Roeck, lm-sensors, linux-kernel

From: Peter Senna Tschudin <peter.senna@gmail.com>

Remove useless kfree() and clean up code related to the removal.

The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
position p1,p2;
expression x;
@@

if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }

@unchanged exists@
position r.p1,r.p2;
expression e <= r.x,x,e1;
iterator I;
statement S;
@@

if (x@p1 == NULL) { ... when != I(x,...) S
                        when != e = e1
                        when != e += e1
                        when != e -= e1
                        when != ++e
                        when != --e
                        when != e++
                        when != e--
                        when != &e
   kfree@p2(x); ... return ...; }

@ok depends on unchanged exists@
position any r.p1;
position r.p2;
expression x;
@@

... when != true x@p1 == NULL
kfree@p2(x);

@depends on !ok && unchanged@
position r.p2;
expression x;
@@

*kfree@p2(x);
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>

---
 drivers/hwmon/asus_atk0110.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
index 4ee5789..cccb0e9 100644
--- a/drivers/hwmon/asus_atk0110.c
+++ b/drivers/hwmon/asus_atk0110.c
@@ -962,7 +962,6 @@ static int atk_add_sensor(struct atk_data *data, union acpi_object *obj)
 
 	return 1;
 out:
-	kfree(sensor->acpi_name);
 	kfree(sensor);
 	return err;
 }


^ permalink raw reply related	[flat|nested] 4+ messages in thread