* [PATCH 0/2] Minimal RAS stuff
@ 2012-09-17 16:52 Borislav Petkov
2012-09-17 16:52 ` [PATCH 1/2] x86, mce: Enable MCA support by default Borislav Petkov
2012-09-17 16:52 ` [PATCH 2/2] x86, MCE: Remove unused defines Borislav Petkov
0 siblings, 2 replies; 6+ messages in thread
From: Borislav Petkov @ 2012-09-17 16:52 UTC (permalink / raw)
To: Tony Luck; +Cc: X86-ML, EDAC devel, LKML, Borislav Petkov
From: Borislav Petkov <borislav.petkov@amd.com>
Ok,
my main intention for this is patch 1/2 which enables MCA by default. I
still see bugreports where CONFIG_X86_MCE is disabled and this is a bad
idea so turning it on by default makes sense to me.
The second patch is only a cleanup.
Thanks.
Borislav Petkov (2):
x86, mce: Enable MCA support by default
x86, MCE: Remove unused defines
arch/x86/Kconfig | 1 +
arch/x86/include/asm/mce.h | 12 +-----------
2 files changed, 2 insertions(+), 11 deletions(-)
--
1.7.11.rc1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] x86, mce: Enable MCA support by default
2012-09-17 16:52 [PATCH 0/2] Minimal RAS stuff Borislav Petkov
@ 2012-09-17 16:52 ` Borislav Petkov
2012-09-17 17:30 ` Luck, Tony
2012-09-17 16:52 ` [PATCH 2/2] x86, MCE: Remove unused defines Borislav Petkov
1 sibling, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2012-09-17 16:52 UTC (permalink / raw)
To: Tony Luck; +Cc: X86-ML, EDAC devel, LKML, Borislav Petkov
From: Borislav Petkov <borislav.petkov@amd.com>
MCA is the basic support for hardware error logging and reporting, and
it is majorly unwise to run without it so enable machine check software
support by default on x86.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
arch/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 8ec3a1aa4abd..3d2d2ef0e16a 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -871,6 +871,7 @@ config X86_REROUTE_FOR_BROKEN_BOOT_IRQS
config X86_MCE
bool "Machine Check / overheating reporting"
+ default y
---help---
Machine Check support allows the processor to notify the
kernel if it detects a problem (e.g. overheating, data corruption).
--
1.7.11.rc1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] x86, MCE: Remove unused defines
2012-09-17 16:52 [PATCH 0/2] Minimal RAS stuff Borislav Petkov
2012-09-17 16:52 ` [PATCH 1/2] x86, mce: Enable MCA support by default Borislav Petkov
@ 2012-09-17 16:52 ` Borislav Petkov
1 sibling, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2012-09-17 16:52 UTC (permalink / raw)
To: Tony Luck; +Cc: X86-ML, EDAC devel, LKML, Borislav Petkov
From: Borislav Petkov <borislav.petkov@amd.com>
Those were sitting there unused since the dawn of time, drop them.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
arch/x86/include/asm/mce.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
index a3ac52b29cbf..ccaf7c581c8f 100644
--- a/arch/x86/include/asm/mce.h
+++ b/arch/x86/include/asm/mce.h
@@ -116,19 +116,9 @@ struct mce_log {
/* Software defined banks */
#define MCE_EXTENDED_BANK 128
#define MCE_THERMAL_BANK MCE_EXTENDED_BANK + 0
-
-#define K8_MCE_THRESHOLD_BASE (MCE_EXTENDED_BANK + 1) /* MCE_AMD */
-#define K8_MCE_THRESHOLD_BANK_0 (MCE_THRESHOLD_BASE + 0 * 9)
-#define K8_MCE_THRESHOLD_BANK_1 (MCE_THRESHOLD_BASE + 1 * 9)
-#define K8_MCE_THRESHOLD_BANK_2 (MCE_THRESHOLD_BASE + 2 * 9)
-#define K8_MCE_THRESHOLD_BANK_3 (MCE_THRESHOLD_BASE + 3 * 9)
-#define K8_MCE_THRESHOLD_BANK_4 (MCE_THRESHOLD_BASE + 4 * 9)
-#define K8_MCE_THRESHOLD_BANK_5 (MCE_THRESHOLD_BASE + 5 * 9)
-#define K8_MCE_THRESHOLD_DRAM_ECC (MCE_THRESHOLD_BANK_4 + 0)
-
+#define K8_MCE_THRESHOLD_BASE (MCE_EXTENDED_BANK + 1)
#ifdef __KERNEL__
-
extern void mce_register_decode_chain(struct notifier_block *nb);
extern void mce_unregister_decode_chain(struct notifier_block *nb);
--
1.7.11.rc1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] x86, mce: Enable MCA support by default
2012-09-17 16:52 ` [PATCH 1/2] x86, mce: Enable MCA support by default Borislav Petkov
@ 2012-09-17 17:30 ` Luck, Tony
2012-09-17 17:32 ` Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: Luck, Tony @ 2012-09-17 17:30 UTC (permalink / raw)
To: Borislav Petkov; +Cc: X86-ML, EDAC devel, LKML, Borislav Petkov
> MCA is the basic support for hardware error logging and reporting, and
> it is majorly unwise to run without it so enable machine check software
> support by default on x86.
Acked-by: Tony Luck <tony.luck@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] x86, mce: Enable MCA support by default
2012-09-17 17:30 ` Luck, Tony
@ 2012-09-17 17:32 ` Borislav Petkov
2012-09-18 9:34 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2012-09-17 17:32 UTC (permalink / raw)
To: Luck, Tony; +Cc: X86-ML, EDAC devel, LKML
On Mon, Sep 17, 2012 at 05:30:00PM +0000, Luck, Tony wrote:
> > MCA is the basic support for hardware error logging and reporting, and
> > it is majorly unwise to run without it so enable machine check software
> > support by default on x86.
>
> Acked-by: Tony Luck <tony.luck@intel.com>
Thanks Tony.
Will send a pull request shortly.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] x86, mce: Enable MCA support by default
2012-09-17 17:32 ` Borislav Petkov
@ 2012-09-18 9:34 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2012-09-18 9:34 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Luck, Tony, X86-ML, EDAC devel, LKML
Em 17-09-2012 14:32, Borislav Petkov escreveu:
> On Mon, Sep 17, 2012 at 05:30:00PM +0000, Luck, Tony wrote:
>>> MCA is the basic support for hardware error logging and reporting, and
>>> it is majorly unwise to run without it so enable machine check software
>>> support by default on x86.
>>
>> Acked-by: Tony Luck <tony.luck@intel.com>
>
> Thanks Tony.
>
> Will send a pull request shortly.
Sounds fine for me too. You can add my ack.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-18 9:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-17 16:52 [PATCH 0/2] Minimal RAS stuff Borislav Petkov
2012-09-17 16:52 ` [PATCH 1/2] x86, mce: Enable MCA support by default Borislav Petkov
2012-09-17 17:30 ` Luck, Tony
2012-09-17 17:32 ` Borislav Petkov
2012-09-18 9:34 ` Mauro Carvalho Chehab
2012-09-17 16:52 ` [PATCH 2/2] x86, MCE: Remove unused defines Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).