From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Feng Tang <feng.tang@intel.com>,
Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 12/18] perf symbols: Filter samples with unresolved symbol when "--symbols" option is used
Date: Mon, 17 Sep 2012 14:18:06 -0300 [thread overview]
Message-ID: <1347902292-14536-13-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1347902292-14536-1-git-send-email-acme@infradead.org>
From: Feng Tang <feng.tang@intel.com>
Report/top commands support to only handle specific symbols with
"--symbols" option, but current code will keep those samples whose
symbol can't be resolved, which should actually be filtered.
If we run following commands:
$perf record -a tree
$perf report --symbols intel_idle -n
the output will be:
Without the patch:
==================
46.27% 156 sshd [unknown]
26.05% 48 swapper [kernel.kallsyms]
17.26% 38 tree libc-2.12.1.so
7.69% 17 tree tree
2.73% 6 tree ld-2.12.1.so
With the patch:
===============
100.00% 48 swapper [kernel.kallsyms]
Signed-off-by: Feng Tang <feng.tang@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1347007349-3102-2-git-send-email-feng.tang@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/event.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 8202f5c..6715b19 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -904,8 +904,9 @@ int perf_event__preprocess_sample(const union perf_event *event,
al->sym = map__find_symbol(al->map, al->addr, filter);
}
- if (symbol_conf.sym_list && al->sym &&
- !strlist__has_entry(symbol_conf.sym_list, al->sym->name))
+ if (symbol_conf.sym_list &&
+ (!al->sym || !strlist__has_entry(symbol_conf.sym_list,
+ al->sym->name)))
goto out_filtered;
return 0;
--
1.7.1
next prev parent reply other threads:[~2012-09-17 17:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1347902292-14536-1-git-send-email-acme@infradead.org>
2012-09-17 17:17 ` [PATCH 01/18] perf probe: Add union member access support Arnaldo Carvalho de Melo
2012-09-17 17:17 ` [PATCH 02/18] perf test: Fixup for the die() removal Arnaldo Carvalho de Melo
2012-09-17 17:17 ` [PATCH 03/18] perf sched: " Arnaldo Carvalho de Melo
2012-09-17 17:17 ` [PATCH 04/18] tools lib traceevent: Define _GNU_SOURCE in Makefile Arnaldo Carvalho de Melo
2012-09-17 17:17 ` [PATCH 05/18] perf hists browser: Fix output for 100.00% Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 06/18] perf hists browser: Fix first column printing Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 07/18] perf tools: Add sort__has_sym Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 08/18] perf report: Enable integrated annotation only if possible Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 09/18] perf stat: Move stats related code to util/stat.c Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 10/18] perf archive: Remove -f from the rm command Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 11/18] perf archive: Make 'f' the last parameter for tar Arnaldo Carvalho de Melo
2012-09-17 17:18 ` Arnaldo Carvalho de Melo [this message]
2012-09-17 17:18 ` [PATCH 13/18] perf scripts: Add --symbols option to handle specific symbols Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 14/18] perf scripts: Add event_analyzing_sample-record/report Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 15/18] perf scripts: Export a find_scripts() function Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 16/18] perf report: Add missing perf_hpp__init for pipe-mode Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 17/18] perf/x86: Add cpumask for uncore pmu Arnaldo Carvalho de Melo
2012-09-17 17:18 ` [PATCH 18/18] perf stat: Check PMU cpumask file Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347902292-14536-13-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).