linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] serial: set correct baud_base for EXSYS EX-41092 Dual 16950
@ 2012-09-17 18:53 Flavio Leitner
  2012-09-21 16:49 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Flavio Leitner @ 2012-09-17 18:53 UTC (permalink / raw)
  To: linux-serial, linux-kernel; +Cc: Niels de Vos, Alan Cox, Flavio Leitner

Apparently the same card model has two IDs, so this patch
complements the commit 39aced68d664291db3324d0fcf0985ab5626aac2
adding the missing one.

Signed-off-by: Flavio Leitner <fbl@redhat.com>
---
 drivers/tty/serial/8250/8250_pci.c | 7 +++++--
 include/linux/pci_ids.h            | 3 ++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 28e7c7c..6fe88e6 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -3232,8 +3232,11 @@ static struct pci_device_id serial_pci_tbl[] = {
 		 * For now just used the hex ID 0x950a.
 		 */
 	{	PCI_VENDOR_ID_OXSEMI, 0x950a,
-		PCI_SUBVENDOR_ID_SIIG, PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL, 0, 0,
-		pbn_b0_2_115200 },
+		PCI_SUBVENDOR_ID_SIIG, PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL_00,
+		0, 0, pbn_b0_2_115200 },
+	{	PCI_VENDOR_ID_OXSEMI, 0x950a,
+		PCI_SUBVENDOR_ID_SIIG, PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL_30,
+		0, 0, pbn_b0_2_115200 },
 	{	PCI_VENDOR_ID_OXSEMI, 0x950a,
 		PCI_ANY_ID, PCI_ANY_ID, 0, 0,
 		pbn_b0_2_1130000 },
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 6b4565c..4242013 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -1847,7 +1847,8 @@
 #define PCI_DEVICE_ID_SIIG_8S_20x_650	0x2081
 #define PCI_DEVICE_ID_SIIG_8S_20x_850	0x2082
 #define PCI_SUBDEVICE_ID_SIIG_QUARTET_SERIAL	0x2050
-#define PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL	0x2530
+#define PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL_00	0x2500
+#define PCI_SUBDEVICE_ID_SIIG_DUAL_SERIAL_30	0x2530
 
 #define PCI_VENDOR_ID_RADISYS		0x1331
 
-- 
1.7.11.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] serial: set correct baud_base for EXSYS EX-41092 Dual 16950
  2012-09-17 18:53 [PATCH] serial: set correct baud_base for EXSYS EX-41092 Dual 16950 Flavio Leitner
@ 2012-09-21 16:49 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2012-09-21 16:49 UTC (permalink / raw)
  To: Flavio Leitner; +Cc: linux-serial, linux-kernel, Niels de Vos, Alan Cox

On Mon, Sep 17, 2012 at 03:53:41PM -0300, Flavio Leitner wrote:
> Apparently the same card model has two IDs, so this patch
> complements the commit 39aced68d664291db3324d0fcf0985ab5626aac2
> adding the missing one.
> 
> Signed-off-by: Flavio Leitner <fbl@redhat.com>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 7 +++++--
>  include/linux/pci_ids.h            | 3 ++-

Please read the top of the pci_ids.h file for why we don't want to add
new entries there.

Please fix that up and resend this.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-21 19:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-17 18:53 [PATCH] serial: set correct baud_base for EXSYS EX-41092 Dual 16950 Flavio Leitner
2012-09-21 16:49 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).