From: Pantelis Antoniou <panto@antoniou-consulting.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Porter <mporter@ti.com>,
Koen Kooi <koen@dominion.thruhere.net>,
Shubhrajyoti D <shubhrajyoti@ti.com>,
Tony Lindgren <tony@atomide.com>,
Pantelis Antoniou <panto@antoniou-consulting.com>
Subject: [PATCH 3/3] i2c: OMAP fix driver initialization message
Date: Wed, 19 Sep 2012 19:07:21 +0300 [thread overview]
Message-ID: <1348070841-23354-4-git-send-email-panto@antoniou-consulting.com> (raw)
In-Reply-To: <1348070841-23354-1-git-send-email-panto@antoniou-consulting.com>
The message spit out when the i2c-omap driver load is printing
the platform device's id as a bus number. However when booting
from OF id is -1, which is not so nice.
Fix it by printing the adapter number.
[ 0.210467] omap_i2c 44e0b000.i2c: bus -1 rev2.4.0 at 400 kHz
vs
[ 0.210467] omap_i2c 44e0b000.i2c: bus 0 rev2.4.0 at 400 kHz
Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
---
drivers/i2c/busses/i2c-omap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index f722478..87bb705 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1178,9 +1178,6 @@ omap_i2c_probe(struct platform_device *pdev)
goto err_unuse_clocks;
}
- dev_info(dev->dev, "bus %d rev%d.%d.%d at %d kHz\n", pdev->id,
- dev->dtrev, dev->rev >> 4, dev->rev & 0xf, dev->speed);
-
adap = &dev->adapter;
i2c_set_adapdata(adap, dev);
adap->owner = THIS_MODULE;
@@ -1204,6 +1201,9 @@ omap_i2c_probe(struct platform_device *pdev)
if (IS_ERR(pinctrl))
dev_warn(dev->dev, "pins are not configured from the driver\n");
+ dev_info(dev->dev, "bus %d rev%d.%d.%d at %d kHz\n", adap->nr,
+ dev->dtrev, dev->rev >> 4, dev->rev & 0xf, dev->speed);
+
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev);
--
1.7.12
next prev parent reply other threads:[~2012-09-18 18:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 16:07 [PATCH 0/3] Pinctrl-fy OMAP I2C driver Pantelis Antoniou
2012-09-19 16:07 ` [PATCH 1/3] pinctrl: pinctrl-single must be initialized early Pantelis Antoniou
2012-09-18 18:21 ` Tony Lindgren
2012-09-18 19:10 ` Pantelis Antoniou
2012-09-21 0:09 ` Tony Lindgren
2012-09-19 16:07 ` [PATCH 2/3] OMAP i2c: pinctrl-ify i2c-omap.c Pantelis Antoniou
2012-09-18 18:23 ` Tony Lindgren
2012-09-18 19:37 ` Pantelis Antoniou
2012-09-19 7:09 ` Shubhrajyoti
2012-09-19 8:34 ` Pantelis Antoniou
2012-09-20 6:34 ` [PATCH 0/2] Pinctrl-fy OMAP I2C driver (V2) Pantelis Antoniou
2012-09-20 6:34 ` [PATCH 1/2] pinctrl: pinctrl-single must be initialized early Pantelis Antoniou
2012-09-20 6:34 ` [PATCH 2/2] OMAP i2c: pinctrl-ify i2c-omap.c Pantelis Antoniou
2012-09-19 10:13 ` Shubhrajyoti Datta
2012-09-19 17:24 ` Tony Lindgren
2012-09-21 7:29 ` [PATCH 2/3] " Peter Ujfalusi
2012-09-21 7:34 ` Pantelis Antoniou
2012-09-19 16:07 ` Pantelis Antoniou [this message]
2012-09-18 18:24 ` [PATCH 3/3] i2c: OMAP fix driver initialization message Tony Lindgren
2012-09-18 19:24 ` a0919096
2012-09-19 9:57 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348070841-23354-4-git-send-email-panto@antoniou-consulting.com \
--to=panto@antoniou-consulting.com \
--cc=b-cousson@ti.com \
--cc=koen@dominion.thruhere.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=shubhrajyoti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).