From: Paul Bolle <pebolle@tiscali.nl>
To: Joe Perches <joe@perches.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Cc: levinsasha928@gmail.com, linux-kernel@vger.kernel.org
Subject: x86: "Fast TSC calibration failed" error
Date: Mon, 24 Sep 2012 14:04:19 +0200
Message-ID: <1348488259.1436.22.camel@x61.thuisdomein> (raw)
0) In the dmesg output of the current session of a laptop I noticed:
<3>[ 0.000000] tsc: Fast TSC calibration failed
(Apparently, this calibration succeeds most of the times, because most
previous sessions have "Fast TSC calibration using PIT" in their log.)
1) This message was upgraded to an error in commit
c767a54ba0657e52e6edaa97cbe0b0a8bf1c1655 ("x86/debug: Add KERN_<LEVEL>
to bare printks, convert printks to pr_<level>"). That commit was
included in mainline in v3.6-rc1. Before that commit this message was
printed at default level (ie, as a warning).
2) Why is this message printed as an error?
3) Let's add some background. This message is printed by
quick_pit_calibrate(), which is only called by native_calibrate_tsc().
If it is printed (quick_pit_calibrate() will return 0 and)
native_calibrate_tsc() will try an alternative calibration strategy. But
in that alternative strategy no message ever exceeds warning level, even
if calibration fails.
4) So, without even understanding why tsc calibration is needed, it does
look unnecessary to print "Fast TSC calibration failed" at error level.
If that's correct, I'd be happy to submit the trivial patch to downgrade
it to (say) informational level.
Paul Bolle
next reply index
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 12:04 Paul Bolle [this message]
2012-09-24 22:22 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348488259.1436.22.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
linux-kernel@vger.kernel.org
public-inbox-index lkml
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git