From: Li Zhong <zhong@linux.vnet.ibm.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH scsi] Short the path length of scsi_cmd_to_driver()
Date: Fri, 28 Sep 2012 15:13:30 +0800 [thread overview]
Message-ID: <1348816410.2419.14.camel@ThinkPad-T420> (raw)
In-Reply-To: <yq1a9wb8iq1.fsf@sermon.lab.mkp.net>
On Thu, 2012-09-27 at 13:43 -0400, Martin K. Petersen wrote:
> >>>>> "Li" == Li Zhong <zhong@linux.vnet.ibm.com> writes:
>
> > @@ -845,8 +844,11 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd,
> >
> > scsi_eh_restore_cmnd(scmd, &ses);
> >
> >- if (sdrv && sdrv->eh_action)
> >- rtn = sdrv->eh_action(scmd, cmnd, cmnd_size, rtn);
> >+ if (scmd->request->cmd_type == REQ_TYPE_FS) {
> >+ struct scsi_driver *sdrv = scsi_cmd_to_driver(scmd);
> >+ if (sdrv->eh_action)
> >+ rtn = sdrv->eh_action(scmd, cmnd, cmnd_size, rtn);
> >+ }
> >
> > return rtn;
> > }
>
> My only concern is whether our device lifetime rules guarantee that the
> ULD is always attached when we service an error handling command?
Thank you, Martin, for the review.
I don't know much about scsi, it might take me some more time to have an
answer to the above question.
For now, if I understand correctly, maybe we could only do the
not-consistent behaviours bug fix? Or could we provide two versions of
scsi_cmd_to_driver(), one with NULL checking for scsi_send_eh_cmnd(),
one without the checking for scsi_finish_command()?
Thanks, Zhong
next prev parent reply other threads:[~2012-09-28 7:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 5:30 [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver() Li Zhong
2012-09-24 5:44 ` James Bottomley
2012-09-24 7:03 ` Li Zhong
2012-09-24 7:35 ` James Bottomley
2012-09-24 9:25 ` Li Zhong
2012-09-24 9:33 ` James Bottomley
2012-09-27 2:02 ` Martin K. Petersen
2012-09-27 4:44 ` James Bottomley
2012-09-27 9:51 ` [PATCH scsi] Short the path length of scsi_cmd_to_driver() Li Zhong
2012-09-27 17:43 ` Martin K. Petersen
2012-09-28 7:13 ` Li Zhong [this message]
2012-09-28 7:45 ` James Bottomley
2012-09-27 17:41 ` [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver() Martin K. Petersen
2012-09-28 7:48 ` James Bottomley
2012-09-29 4:23 ` [PATCH v2 scsi] Short the path length of scsi_cmd_to_driver() Li Zhong
2012-10-02 22:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348816410.2419.14.camel@ThinkPad-T420 \
--to=zhong@linux.vnet.ibm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).