From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754341Ab2JJQOO (ORCPT ); Wed, 10 Oct 2012 12:14:14 -0400 Received: from webmail.solarflare.com ([12.187.104.25]:18958 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751717Ab2JJQOJ (ORCPT ); Wed, 10 Oct 2012 12:14:09 -0400 Message-ID: <1349885644.6336.70.camel@deadeye.wl.decadent.org.uk> Subject: Re: [PATCH 11/11] net: xilinx: Show csum in bootlog From: Ben Hutchings To: Michal Simek CC: , , Anirudha Sarangi , John Linn , Grant Likely , Rob Herring , "David S. Miller" , John Linn Date: Wed, 10 Oct 2012 17:14:04 +0100 In-Reply-To: References: <1349374497-9540-1-git-send-email-monstr@monstr.eu> <1349374497-9540-11-git-send-email-monstr@monstr.eu> <1349378144.2817.23.camel@bwh-desktop.uk.solarflarecom.com> <506EA9C4.2000609@monstr.eu> <1349445062.16173.48.camel@deadeye.wl.decadent.org.uk> <5073E988.60701@monstr.eu> <1349801800.2800.21.camel@bwh-desktop.uk.solarflarecom.com> Organization: Solarflare Communications Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [88.96.1.126] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-10-10 at 18:06 +0200, Michal Simek wrote: > 2012/10/9 Ben Hutchings : > > On Tue, 2012-10-09 at 11:08 +0200, Michal Simek wrote: > >> On 10/05/2012 03:51 PM, Ben Hutchings wrote: > >> > On Fri, 2012-10-05 at 11:35 +0200, Michal Simek wrote: > >> >> On 10/04/2012 09:15 PM, Ben Hutchings wrote: > >> >>> On Thu, 2012-10-04 at 20:14 +0200, Michal Simek wrote: > >> >>>> Just show current setting in bootlog. > >> >>> [...] > >> >>>> --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > >> >>>> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > >> >>>> @@ -1052,12 +1052,14 @@ static int __devinit temac_of_probe(struct platform_device *op) > >> >>>> /* Setup checksum offload, but default to off if not specified */ > >> >>>> lp->temac_features = 0; > >> >>>> p = (__be32 *)of_get_property(op->dev.of_node, "xlnx,txcsum", NULL); > >> >>>> + dev_info(&op->dev, "TX_CSUM %d\n", be32_to_cpup(p)); > >> >>>> if (p && be32_to_cpu(*p)) { > >> >>>> lp->temac_features |= TEMAC_FEATURE_TX_CSUM; > >> >>>> /* Can checksum TCP/UDP over IPv4. */ > >> >>>> ndev->features |= NETIF_F_IP_CSUM; > >> >>>> } > >> >>>> p = (__be32 *)of_get_property(op->dev.of_node, "xlnx,rxcsum", NULL); > >> >>>> + dev_info(&op->dev, "RX_CSUM %d\n", be32_to_cpup(p)); > >> >>> [...] > >> >>> > >> >>> Is there any particular reason you think this needs to be logged by > >> >>> default, rather than letting users run ethtool -k? I suggest using > >> >>> dev_dbg() instead. > >> >> > >> >> Ok. I have looked at it and there are missing some bits in ndev->features. > >> >> > >> >> Can you please check that my setting is correct? > >> >> > >> >> It is SG DMA ip/driver. > >> >> ndev->features = NETIF_F_FRAGLIST | NETIF_F_SG > >> > > >> > NETIF_F_SG only; NETIF_F_FRAGLIST means you can handle skbs chained > >> > through the frag_list pointer. > >> > >> The driver is able to handle skb fragments too. temac_start_xmit > > > > "git grep -w -E 'frag_list|skb_walk_frags|skb_to_sgvec' drivers/net/ethernet/xilinx" > > returns nothing in net-next. > > What about this? Maybe it is different fragmentation. > drivers/net/ethernet/xilinx/ll_temac_main.c > 688 num_frag = skb_shinfo(skb)->nr_frags; > 689 frag = &skb_shinfo(skb)->frags[0]; [...] Yes, the fact that you handle the frags array is indicated by feature flag NETIF_F_SG. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.