From: Toshi Kani <toshi.kani@hp.com>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: linux-acpi@vger.kernel.org, lenb@kernel.org,
linux-kernel@vger.kernel.org, rjw@sisk.pl, liuj97@gmail.com
Subject: Re: [PATCH 2/2] ACPI: Remove unused lockable in acpi_device_flags
Date: Wed, 17 Oct 2012 07:56:49 -0600 [thread overview]
Message-ID: <1350482209.28185.2.camel@misato.fc.hp.com> (raw)
In-Reply-To: <507E0942.1080708@jp.fujitsu.com>
On Wed, 2012-10-17 at 10:26 +0900, Yasuaki Ishimatsu wrote:
> 2012/10/16 1:34, Toshi Kani wrote:
> > Removed lockable in struct acpi_device_flags since it is no
> > longer used by any code. acpi_bus_hot_remove_device() cannot
> > use this flag because acpi_bus_trim() frees up its acpi_device
> > object. Furthermore, the dock driver calls _LCK method without
> > using this lockable flag.
> >
> > Signed-off-by: Toshi Kani <toshi.kani@hp.com>
>
> Looks good to me.
> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thanks Yasuaki for reviewing!
-Toshi
> > ---
> > drivers/acpi/scan.c | 5 -----
> > include/acpi/acpi_bus.h | 3 +--
> > 2 files changed, 1 insertion(+), 7 deletions(-)
> >
> > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> > index ed87f43..19d3d4a 100644
> > --- a/drivers/acpi/scan.c
> > +++ b/drivers/acpi/scan.c
> > @@ -1017,11 +1017,6 @@ static int acpi_bus_get_flags(struct acpi_device *device)
> > device->flags.ejectable = 1;
> > }
> >
> > - /* Presence of _LCK indicates 'lockable' */
> > - status = acpi_get_handle(device->handle, "_LCK", &temp);
> > - if (ACPI_SUCCESS(status))
> > - device->flags.lockable = 1;
> > -
> > /* Power resources cannot be power manageable. */
> > if (device->device_type == ACPI_BUS_TYPE_POWER)
> > return 0;
> > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
> > index 0daa0fb..e8b2877 100644
> > --- a/include/acpi/acpi_bus.h
> > +++ b/include/acpi/acpi_bus.h
> > @@ -144,12 +144,11 @@ struct acpi_device_flags {
> > u32 bus_address:1;
> > u32 removable:1;
> > u32 ejectable:1;
> > - u32 lockable:1;
> > u32 suprise_removal_ok:1;
> > u32 power_manageable:1;
> > u32 performance_manageable:1;
> > u32 eject_pending:1;
> > - u32 reserved:23;
> > + u32 reserved:24;
> > };
> >
> > /* File System */
> >
>
>
next prev parent reply other threads:[~2012-10-17 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 16:34 [PATCH 1/2] ACPI: Fix stale pointer access to flags.lockable Toshi Kani
2012-10-15 16:34 ` [PATCH 2/2] ACPI: Remove unused lockable in acpi_device_flags Toshi Kani
2012-10-17 1:26 ` Yasuaki Ishimatsu
2012-10-17 13:56 ` Toshi Kani [this message]
2012-10-24 22:08 ` Rafael J. Wysocki
2012-10-25 14:01 ` Toshi Kani
2012-10-17 1:25 ` [PATCH 1/2] ACPI: Fix stale pointer access to flags.lockable Yasuaki Ishimatsu
2012-10-17 13:55 ` Toshi Kani
2012-10-24 22:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350482209.28185.2.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).