From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Joe Perches <joe@perches.com>
Cc: netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1
Date: Wed, 24 Oct 2012 04:00:21 -0700 [thread overview]
Message-ID: <1351076421.25066.14.camel@jtkirshe-mobl> (raw)
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
With the recent commit to checkpatch.pl:
commit 058806007450489bb8f457b275e5cb5c946320c1
Author: Joe Perches <joe@perches.com>
Date: Thu Oct 4 17:13:35 2012 -0700
checkpatch: check networking specific block comment style
We are seeing false positive warnings. Here is an example of the
code the would generate a false warning:
#define foo 0x0000 /* foo comment */
checkpatch.pl generates a warnings that the */ should be on a separate
line, which in this case is incorrect.
I apologize for not digging into the checkpatch.pl code to provide a
fix, I figure Joe (or anyone else with great checkpatch kung fu) can
figure out the issue and fix it faster than I could. :-)
Cheers,
Jeff
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2012-10-24 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 11:00 Jeff Kirsher [this message]
2012-10-24 14:12 ` [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1 Joe Perches
2012-10-24 20:51 ` Jeff Kirsher
2012-10-24 21:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351076421.25066.14.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).