From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934900Ab2JXOMT (ORCPT ); Wed, 24 Oct 2012 10:12:19 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:43374 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756111Ab2JXOMR (ORCPT ); Wed, 24 Oct 2012 10:12:17 -0400 Message-ID: <1351087936.18179.9.camel@joe-AO722> Subject: Re: [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1 From: Joe Perches To: jeffrey.t.kirsher@intel.com Cc: netdev , LKML Date: Wed, 24 Oct 2012 07:12:16 -0700 In-Reply-To: <1351076421.25066.14.camel@jtkirshe-mobl> References: <1351076421.25066.14.camel@jtkirshe-mobl> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote: > With the recent commit to checkpatch.pl: > > commit 058806007450489bb8f457b275e5cb5c946320c1 > Author: Joe Perches > Date: Thu Oct 4 17:13:35 2012 -0700 > > checkpatch: check networking specific block comment style > > We are seeing false positive warnings. Here is an example of the > code the would generate a false warning: > > #define foo 0x0000 /* foo comment */ > > checkpatch.pl generates a warnings that the */ should be on a separate > line, which in this case is incorrect. Sorry 'bout that. I believe it's fixed by: https://lkml.org/lkml/2012/10/14/267