[PATCH 1/2] Remove CsrEventHandle and functions using it

[PATCH 1/2] Remove CsrEventHandle and functions using it

[SeongJae Park]

Nobody use CsrEventHandle, Nobody call function using it as parameter.
So, remove it.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 drivers/staging/csr/csr_framework_ext.h       |   61 -------------------------
 drivers/staging/csr/csr_framework_ext_types.h |    2 -
 2 files changed, 63 deletions(-)

diff --git a/drivers/staging/csr/csr_framework_ext.h b/drivers/staging/csr/csr_framework_ext.h
index 66973e9..7cfbd48 100644
--- a/drivers/staging/csr/csr_framework_ext.h
+++ b/drivers/staging/csr/csr_framework_ext.h
@@ -36,67 +36,6 @@ extern "C" {
 
 /*----------------------------------------------------------------------------*
  *  NAME
- *      CsrEventCreate
- *
- *  DESCRIPTION
- *      Creates an event and returns a handle to the created event.
- *
- *  RETURNS
- *      Possible values:
- *          CSR_RESULT_SUCCESS          in case of success
- *          CSR_FE_RESULT_NO_MORE_EVENTS   in case of out of event resources
- *          CSR_FE_RESULT_INVALID_POINTER  in case the eventHandle pointer is invalid
- *
- *----------------------------------------------------------------------------*/
-CsrResult CsrEventCreate(CsrEventHandle *eventHandle);
-
-/*----------------------------------------------------------------------------*
- *  NAME
- *      CsrEventWait
- *
- *  DESCRIPTION
- *      Wait fore one or more of the event bits to be set.
- *
- *  RETURNS
- *      Possible values:
- *          CSR_RESULT_SUCCESS              in case of success
- *          CSR_FE_RESULT_TIMEOUT              in case of timeout
- *          CSR_FE_RESULT_INVALID_HANDLE       in case the eventHandle is invalid
- *          CSR_FE_RESULT_INVALID_POINTER      in case the eventBits pointer is invalid
- *
- *----------------------------------------------------------------------------*/
-CsrResult CsrEventWait(CsrEventHandle *eventHandle, u16 timeoutInMs, u32 *eventBits);
-
-/*----------------------------------------------------------------------------*
- *  NAME
- *      CsrEventSet
- *
- *  DESCRIPTION
- *      Set an event.
- *
- *  RETURNS
- *      Possible values:
- *          CSR_RESULT_SUCCESS              in case of success
- *          CSR_FE_RESULT_INVALID_HANDLE       in case the eventHandle is invalid
- *
- *----------------------------------------------------------------------------*/
-CsrResult CsrEventSet(CsrEventHandle *eventHandle, u32 eventBits);
-
-/*----------------------------------------------------------------------------*
- *  NAME
- *      CsrEventDestroy
- *
- *  DESCRIPTION
- *      Destroy the event associated.
- *
- *  RETURNS
- *      void
- *
- *----------------------------------------------------------------------------*/
-void CsrEventDestroy(CsrEventHandle *eventHandle);
-
-/*----------------------------------------------------------------------------*
- *  NAME
  *      CsrMutexCreate
  *
  *  DESCRIPTION
diff --git a/drivers/staging/csr/csr_framework_ext_types.h b/drivers/staging/csr/csr_framework_ext_types.h
index 57194ee..d97c2de 100644
--- a/drivers/staging/csr/csr_framework_ext_types.h
+++ b/drivers/staging/csr/csr_framework_ext_types.h
@@ -37,7 +37,6 @@ struct CsrEvent
     unsigned int      wakeup_flag;
 };
 
-typedef struct CsrEvent CsrEventHandle;
 typedef struct semaphore CsrMutexHandle;
 typedef struct CsrThread CsrThreadHandle;
 
@@ -50,7 +49,6 @@ struct CsrEvent
     u32       eventBits;
 };
 
-typedef struct CsrEvent CsrEventHandle;
 typedef pthread_mutex_t CsrMutexHandle;
 typedef pthread_t CsrThreadHandle;
 
-- 
1.7.9.5

[PATCH 2/2] Remove struct CsrEvent

[SeongJae Park]

Nobody use struct CsrEvent. Remove it.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 drivers/staging/csr/csr_framework_ext_types.h |   14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/staging/csr/csr_framework_ext_types.h b/drivers/staging/csr/csr_framework_ext_types.h
index d97c2de..9623eec 100644
--- a/drivers/staging/csr/csr_framework_ext_types.h
+++ b/drivers/staging/csr/csr_framework_ext_types.h
@@ -30,25 +30,11 @@ struct CsrThread
     char                name[16];
 };
 
-struct CsrEvent
-{
-    /* wait_queue for waking the kernel thread */
-    wait_queue_head_t wakeup_q;
-    unsigned int      wakeup_flag;
-};
-
 typedef struct semaphore CsrMutexHandle;
 typedef struct CsrThread CsrThreadHandle;
 
 #else /* __KERNEL __ */
 
-struct CsrEvent
-{
-    pthread_cond_t  event;
-    pthread_mutex_t mutex;
-    u32       eventBits;
-};
-
 typedef pthread_mutex_t CsrMutexHandle;
 typedef pthread_t CsrThreadHandle;
 
-- 
1.7.9.5

Re: [PATCH 1/2] Remove CsrEventHandle and functions using it

[Greg KH]

On Thu, Oct 25, 2012 at 02:51:10PM +0900, SeongJae Park wrote:
> Nobody use CsrEventHandle, Nobody call function using it as parameter.
> So, remove it.
> 
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
>  drivers/staging/csr/csr_framework_ext.h       |   61 -------------------------
>  drivers/staging/csr/csr_framework_ext_types.h |    2 -
>  2 files changed, 63 deletions(-)

This patch applies with fuzz, which implies that you didn't make it
against the latest tree.  Care to redo it, and the 2/2 patch, against
either my staging-next branch of the staging.git tree, or the next
linux-next release that will happen tomorrow, and resend them?

thanks,

greg k-h

Re: [PATCH 1/2] Remove CsrEventHandle and functions using it

[SeongJae Park]

Thank you for comment.
I will make and send patch again.

Thanks and Regards.
SeongJae Park.

On Fri, Oct 26, 2012 at 4:16 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Oct 25, 2012 at 02:51:10PM +0900, SeongJae Park wrote:
>> Nobody use CsrEventHandle, Nobody call function using it as parameter.
>> So, remove it.
>>
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>> ---
>>  drivers/staging/csr/csr_framework_ext.h       |   61 -------------------------
>>  drivers/staging/csr/csr_framework_ext_types.h |    2 -
>>  2 files changed, 63 deletions(-)
>
> This patch applies with fuzz, which implies that you didn't make it
> against the latest tree.  Care to redo it, and the 2/2 patch, against
> either my staging-next branch of the staging.git tree, or the next
> linux-next release that will happen tomorrow, and resend them?
>
> thanks,
>
> greg k-h