From: Ian Campbell <Ian.Campbell@citrix.com>
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: xen-devel <xen-devel@lists.xen.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [Xen-devel] [PATCH 4/5] xen: arm: implement remap interfaces needed for privcmd mappings.
Date: Thu, 25 Oct 2012 08:46:59 +0100 [thread overview]
Message-ID: <1351151219.18035.94.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20121024170746.7c89a790@mantra.us.oracle.com>
On Thu, 2012-10-25 at 01:07 +0100, Mukesh Rathor wrote:
> On Wed, 24 Oct 2012 16:44:11 -0700
> Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
>
> > >
> > > #ifndef HYPERVISOR_VIRT_START
> > > diff --git a/include/xen/interface/memory.h
> > > b/include/xen/interface/memory.h index ad0dff5..5de2b36 100644
> > > --- a/include/xen/interface/memory.h
> > > +++ b/include/xen/interface/memory.h
> > > @@ -188,6 +188,24 @@ DEFINE_GUEST_HANDLE_STRUCT(xen_add_to_physmap);
> > > /*** REMOVED ***/
> > > /*#define XENMEM_translate_gpfn_list 8*/
> > >
> > > +#define XENMEM_add_to_physmap_range 23
> > > +struct xen_add_to_physmap_range {
> > > + /* Which domain to change the mapping for. */
> > > + domid_t domid;
> > > + uint16_t space; /* => enum phys_map_space */
> > > +
> > > + /* Number of pages to go through */
> > > + uint16_t size;
> > > + domid_t foreign_domid; /* IFF gmfn_foreign */
> > > +
> > > + /* Indexes into space being mapped. */
> > > + GUEST_HANDLE(xen_ulong_t) idxs;
> > > +
> > > + /* GPFN in domid where the source mapping page should appear.
> > > */
> > > + GUEST_HANDLE(xen_pfn_t) gpfns;
> >
> >
> > Looking at your arm implementation in xen, doesn't look like you are
> > expecting idxs and gpfns to be contigous. In that case, shouldn't idxs
> > and gpfns be pointers, ie, they are sent down as arrays? Or does
> > GUEST_HANDLE do that, I can't seem to find where it's defined quickly.
>
> Never mind, I see it got corrected to XEN_GUEST_HANDLE in staging tree.
The macro is called XEN_GUEST_HANDLE in Xen and just GUEST_HANDLE in
Linux.
> Still doesn't compile tho:
>
> public/memory.h:246: error: expected specifier-qualifier-list before
> ‘__guest_handle_xen_ulong_t’
>
> I'll figure it out.
Looks like you've got it all sorted?
Ian.
next prev parent reply other threads:[~2012-10-25 7:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 13:19 [PATCH+GIT V3 0/5] arm: implement ballooning and privcmd foreign mappings based on x86 PVH Ian Campbell
2012-10-24 13:19 ` [PATCH 1/5] xen: balloon: allow PVMMU interfaces to be compiled out Ian Campbell
2012-10-24 13:19 ` [PATCH 2/5] xen: arm: enable balloon driver Ian Campbell
2012-10-24 13:19 ` [PATCH 3/5] xen: correctly use xen_pfn_t in remap_domain_mfn_range Ian Campbell
2012-10-24 13:19 ` [PATCH 4/5] xen: arm: implement remap interfaces needed for privcmd mappings Ian Campbell
2012-10-24 13:43 ` Stefano Stabellini
2012-10-24 23:44 ` [Xen-devel] " Mukesh Rathor
2012-10-25 0:07 ` Mukesh Rathor
2012-10-25 0:14 ` Mukesh Rathor
2012-10-25 7:46 ` Ian Campbell [this message]
2012-10-26 1:39 ` Mukesh Rathor
2012-10-26 7:58 ` Ian Campbell
2012-10-24 13:19 ` [PATCH 5/5] xen: x86 pvh: use XENMEM_add_to_physmap_range for foreign gmfn mappings Ian Campbell
2012-10-26 1:38 ` [Xen-devel] " Mukesh Rathor
2012-10-29 14:20 ` [PATCH+GIT V3 0/5] arm: implement ballooning and privcmd foreign mappings based on x86 PVH Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351151219.18035.94.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).