From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
James Bottomley <JBottomley@Parallels.com>,
Christoph Hellwig <hch@lst.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] virtio-scsi: Fix incorrect lock release order in virtscsi_kick_cmd
Date: Fri, 09 Nov 2012 11:31:16 -0800 [thread overview]
Message-ID: <1352489476.29589.544.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <509CC210.8090908@redhat.com>
Hi Paolo,
On Fri, 2012-11-09 at 09:42 +0100, Paolo Bonzini wrote:
> Il 09/11/2012 07:29, Nicholas A. Bellinger ha scritto:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> >
> > This patch fixes a regression bug in virtscsi_kick_cmd() that relinquishes
> > the acquired spinlocks in the incorrect order using the wrong spin_unlock
> > macros, namely releasing vq->vq_lock before tgt->tgt_lock while invoking
> > the calls to virtio_ring.c:virtqueue_add_buf() and friends.
> >
> > This bug was originally introduced in v3.5-rc7 code with:
> >
> > commit 2bd37f0fde99cbf8b78fb55f1128e8c3a63cf1da
> > Author: Paolo Bonzini <pbonzini@redhat.com>
> > Date: Wed Jun 13 16:56:34 2012 +0200
> >
> > [SCSI] virtio-scsi: split scatterlist per target
> >
> > Go ahead and make sure that vq->vq_lock is relinquished w/ spin_unlock
> > first, then release tgt->tgt_lock w/ spin_unlock_irqrestore.
>
> That's done on purpose. After you do virtqueue_add_buf, you don't need
> the sg list anymore, nor the lock that protects it. The cover letter is
> at https://lkml.org/lkml/2012/6/13/295 and had this text:
>
> This series reorganizes the locking in virtio-scsi, introducing
> separate scatterlists for each target and "pipelining" the locks so
> that one command can be queued while the other is prepared. This
> improves performance when there are multiple in-flight operations.
>
> In fact, the patch _introduces_ wrong locking because
> virtqueue_kick_prepare needs the vq_lock.
>
> Perhaps what you want is separate local_irq_save/local_irq_restore?
>
Ahh, that makes more sense now.
Just noticed this while reviewing code that using one spinlock flag's to
release the other looks suspicious, minus the ordering bit..
Using local_irq_* would probably be cleaner than swapping flags between
different locks, and a short comment here would be helpful to explain
the locking order context.
Anyways, no big deal. Thanks for the explanation.
--nab
next prev parent reply other threads:[~2012-11-09 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 6:29 [PATCH] virtio-scsi: Fix incorrect lock release order in virtscsi_kick_cmd Nicholas A. Bellinger
2012-11-09 7:09 ` Wanlong Gao
2012-11-09 8:42 ` Paolo Bonzini
2012-11-09 19:31 ` Nicholas A. Bellinger [this message]
2012-11-09 23:37 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352489476.29589.544.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=JBottomley@Parallels.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).