From: Shuah Khan <shuah.khan@hp.com>
To: David Miller <davem@davemloft.net>
Cc: kyungmin.park@samsung.com, arnd@arndb.de,
m.szyprowski@samsung.com, sam@ravnborg.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
shuahkhan@gmail.com
Subject: Re: [PATCH RFT RESEND linux-next] sparc: dma-mapping: support debug_dma_mapping_error
Date: Fri, 09 Nov 2012 17:52:23 -0700 [thread overview]
Message-ID: <1352508743.5524.41.camel@lorien2> (raw)
In-Reply-To: <20121109.193849.458704479891559672.davem@davemloft.net>
On Fri, 2012-11-09 at 19:38 -0500, David Miller wrote:
> From: Shuah Khan <shuah.khan@hp.com>
> Date: Fri, 26 Oct 2012 10:13:09 -0600
>
> > Add support for debug_dma_mapping_error() call to avoid warning from
> > debug_dma_unmap() interface when it checks for mapping error checked
> > status. Without this patch, device driver failed to check map error
> > warning is generated.
> >
> > Signed-off-by: Shuah Khan <shuah.khan@hp.com>
>
> This doesn't even compile:
>
> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error':
> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma
> _mapping_error' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> In file included from include/linux/dma-mapping.h:76:0,
> from include/linux/skbuff.h:33,
> from include/linux/icmpv6.h:4,
> from include/linux/ipv6.h:58,
> from include/net/ipv6.h:16,
> from include/linux/sunrpc/clnt.h:26,
> from include/linux/nfs_fs.h:30,
> from init/do_mounts.c:30:
The problem the dependent patch is in linux-next and not in arch trees
yet. That is why I am trying it get this through linux-next and/or
dma-debug tree. I am open to suggestions on what is the best route.
linux-next commit-id is:
commit 6c9c6d6301287e369a754d628230fa6e50cdb74b
I have another one that I sent to linux-next that fixes the dependency
on get_dma_ops():
https://lkml.org/lkml/2012/11/3/219
Thanks,
-- Shuah
next prev parent reply other threads:[~2012-11-10 0:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 0:36 [PATCH RFT] sparc: dma-mapping: support debug_dma_mapping_error Shuah Khan
2012-10-26 0:38 ` [PATCH RFT RESEND] " Shuah Khan
2012-10-26 16:13 ` [PATCH RFT RESEND linux-next] " Shuah Khan
2012-10-26 19:01 ` David Miller
2012-10-26 19:10 ` David Miller
2012-10-26 21:40 ` Shuah Khan
2012-11-10 0:38 ` David Miller
2012-11-10 0:52 ` Shuah Khan [this message]
2012-11-10 0:54 ` David Miller
2012-11-10 1:21 ` Shuah Khan
2012-11-15 17:39 ` Shuah Khan
2012-11-17 12:22 ` [PATCH RFT] " Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352508743.5524.41.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sam@ravnborg.org \
--cc=shuahkhan@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).