From: Marek Vasut <marek.vasut@gmail.com>
To: Adam Ford <aford173@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Versaclock usage and improvement question
Date: Tue, 24 Mar 2020 18:30:35 +0100 [thread overview]
Message-ID: <1352fbee-c768-315e-4042-d666db3d9456@gmail.com> (raw)
In-Reply-To: <CAHCN7xLbV5BxD9PYfxNC7M64WK1nf3Y=zfeg=PqF+XgwvyZBjw@mail.gmail.com>
On 3/24/20 6:15 PM, Adam Ford wrote:
> Marek,
Hi,
> I am working on a board that uses two versaclock chips using different
> i2c buses, but it appears to the driver is hard-coding the names of
> the clocks. This appears to be a problem when the second instance is
> loaded, it fails, because the clock names already exist. I am
> inquiring to you as how you'd prefer to see the clock names generated
> so we can do multiple instances. I am planning on using kasprintf and
> following a pattern similar to drivers/clk/keystone/sci-clk.c.
I never had a board with two of them indeed, sorry.
> Secondly, our Versaclock chips are un-programmed, so we need to both
> enable the clock signal and set the output type which means adding a
> few device tree options. I am curious to know if you have an opinion
> on how the new flags should be named.
I'd say, send an RFC patch and let's move on from there ?
The chips I use are factory pre-programmed btw.
> Lastly, we're going to use the versaclock to drive multiple devices,
> and some of them do not call the function to enable the clocks, so we
> need some method to force the clocks on. Is there a method to forcing
> the clock outputs on similar to a gpio-hog holding a GPIO line in a
> known state?
I think something around assigned-clock DT props might help here ?
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2020-03-24 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 17:15 Versaclock usage and improvement question Adam Ford
2020-03-24 17:30 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352fbee-c768-315e-4042-d666db3d9456@gmail.com \
--to=marek.vasut@gmail.com \
--cc=aford173@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).