linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
	Zachary Amsden <zamsden@gmail.com>,
	Matt Fleming <matt.fleming@intel.com>
Subject: [PATCH v3 02/12] x86, boot: Move lldt/ltr out of 64bit code section
Date: Tue, 20 Nov 2012 23:16:00 -0800	[thread overview]
Message-ID: <1353482170-10160-3-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1353482170-10160-1-git-send-email-yinghai@kernel.org>

commit 08da5a2ca

    x86_64: Early segment setup for VT

add lldt/ltr to clean more segments.

Those code are put in code64, and it is using gdt that is only
loaded from code32 path.

That breaks booting with 64bit bootloader that does not go through
code32 path, and get at startup_64 directly, so they have different
gdt.

Move those lines into code32 after their gdt is loaded.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Zachary Amsden <zamsden@gmail.com>
Cc: Matt Fleming <matt.fleming@intel.com>
---
 arch/x86/boot/compressed/head_64.S |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S
index 2c3cee4..375af23 100644
--- a/arch/x86/boot/compressed/head_64.S
+++ b/arch/x86/boot/compressed/head_64.S
@@ -154,6 +154,12 @@ ENTRY(startup_32)
 	btsl	$_EFER_LME, %eax
 	wrmsr
 
+	/* After gdt is loaded */
+	xorl	%eax, %eax
+	lldt	%ax
+	movl    $0x20, %eax
+	ltr	%ax
+
 	/*
 	 * Setup for the jump to 64bit mode
 	 *
@@ -245,9 +251,6 @@ preferred_addr:
 	movl	%eax, %ss
 	movl	%eax, %fs
 	movl	%eax, %gs
-	lldt	%ax
-	movl    $0x20, %eax
-	ltr	%ax
 
 	/*
 	 * Compute the decompressed kernel start address.  It is where
-- 
1.7.7


  parent reply	other threads:[~2012-11-21  7:18 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  7:15 [PATCH v3 00/12] x86, boot, 64bit: Add support for loading ramdisk and bzImage high Yinghai Lu
2012-11-21  7:15 ` [PATCH v3 01/12] x86, boot: move verify_cpu.S after 0x200 Yinghai Lu
2012-11-21 17:23   ` H. Peter Anvin
2012-11-21 19:45     ` Yinghai Lu
2012-11-21 19:50       ` H. Peter Anvin
2012-11-21 20:15         ` Yinghai Lu
2012-11-22  5:48           ` Eric W. Biederman
     [not found]             ` <3178cb29-0e9e-44d2-b21f-45c53f38980a@email.android.com>
2012-11-22 11:27               ` Eric W. Biederman
2012-11-24  7:00                 ` Yinghai Lu
2012-11-21  7:16 ` Yinghai Lu [this message]
2012-11-21  7:16 ` [PATCH v3 03/12] x86, 64bit: set extra ident page table for whole kernel range Yinghai Lu
2012-11-21  7:16 ` [PATCH v3 04/12] x86, 64bit: add support for loading kernel above 512G Yinghai Lu
2012-11-21  7:16 ` [PATCH v3 05/12] x86: Merge early_reserve_initrd for 32bit and 64bit Yinghai Lu
2012-11-21  7:40   ` Pekka Enberg
2012-11-21  7:16 ` [PATCH v3 06/12] x86: add get_ramdisk_image/size Yinghai Lu
2012-11-21  7:16 ` [PATCH v3 07/12] x86, boot: add get_cmd_line_ptr() Yinghai Lu
2012-11-21  7:16 ` [PATCH v3 08/12] x86, boot: Don't check if cmd_line_ptr is accessible in misc/decompressor() Yinghai Lu
2012-11-21 17:21   ` H. Peter Anvin
2012-11-21 19:18     ` Yinghai Lu
2012-11-21  7:16 ` [PATCH v3 09/12] x86, boot: update cmd_line_ptr to unsigned long Yinghai Lu
2012-11-21  7:16 ` [PATCH v3 10/12] x86: use io_remap to access real_mode_data Yinghai Lu
2012-11-21  7:16 ` [PATCH v3 11/12] x86, boot: add fields to support load bzImage and ramdisk high Yinghai Lu
2012-11-21 17:17   ` H. Peter Anvin
2012-11-21 18:59     ` Yinghai Lu
2012-11-21 19:18       ` H. Peter Anvin
2012-11-22  5:56         ` Yinghai Lu
     [not found]           ` <a1ca794a-09d4-4d36-8c8c-67100cb3696e@email.android.com>
2012-11-22  6:47             ` Yinghai Lu
2012-11-22  6:58               ` Yinghai Lu
2012-11-22 15:59                 ` H. Peter Anvin
2012-11-22 18:28                   ` Yinghai Lu
2012-11-22 18:37                     ` H. Peter Anvin
2012-11-22 18:50                       ` Yinghai Lu
2012-11-22 18:51                         ` H. Peter Anvin
2012-11-22 20:18                           ` Yinghai Lu
2012-11-22 20:20                             ` H. Peter Anvin
2012-11-22 20:29                               ` Yinghai Lu
2012-11-22 20:50                             ` H. Peter Anvin
2012-11-22 21:02                               ` H. Peter Anvin
2012-11-22 22:13                                 ` Yinghai Lu
2012-11-24 12:37                       ` Eric W. Biederman
2012-11-24 17:32                         ` H. Peter Anvin
     [not found]                           ` <CAE9FiQV0Q0fi7TrNjihdsUt0ueT4LLON4o+JEmX6ry9S6AU-ug@mail.gmail.com>
2012-11-24 18:24                             ` H. Peter Anvin
2012-11-24 19:50                           ` H. Peter Anvin
2012-11-24 21:30                             ` Yinghai Lu
2012-11-24 21:38                               ` H. Peter Anvin
2012-11-24 22:18                                 ` Yinghai Lu
2012-11-24 22:32                                   ` H. Peter Anvin
2012-11-24 23:24                                     ` Yinghai Lu
2012-11-24 23:50                             ` Eric W. Biederman
2012-11-25  0:04                               ` H. Peter Anvin
2012-11-25  0:11                                 ` Yinghai Lu
2012-11-25  5:50                                   ` Yinghai Lu
2012-11-25  5:52                                     ` H. Peter Anvin
2012-11-25  6:09                                       ` Yinghai Lu
2012-11-25  0:04                               ` Yinghai Lu
2012-11-25  0:06                                 ` H. Peter Anvin
2012-11-21  7:16 ` [PATCH v3 12/12] x86: remove 1024g limitation for kexec buffer on 64bit Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353482170-10160-3-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=zamsden@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).