From: Zhang Rui <rui.zhang@intel.com>
To: Amit Kachhap <amit.kachhap@linaro.org>
Cc: linux-pm@lists.linux-foundation.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
durgadoss.r@intel.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, jonghwa3.lee@samsung.com
Subject: Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling
Date: Thu, 22 Nov 2012 16:12:31 +0800 [thread overview]
Message-ID: <1353571951.2297.7.camel@rzhang1-mobl4> (raw)
In-Reply-To: <CAK44p21mnUpWpHWui6yFqaE5mrjTHhx48j3Mgm0K-KL3EskaGA@mail.gmail.com>
On Thu, 2012-11-22 at 10:11 +0530, Amit Kachhap wrote:
> On 22 November 2012 06:52, Zhang Rui <rui.zhang@intel.com> wrote:
> > On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote:
> >> This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL
> >> and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly
> >> jump to the upper or lower cooling level instead of incremental increase
> >> or decrease. This is needed for temperature sensors which support rising/falling
> >> threshold interrupts and polling can be totally avoided.
> >>
> >> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> >> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@linaro.org>
> >> ---
> >> drivers/thermal/step_wise.c | 19 +++++++++++++++----
> >> include/linux/thermal.h | 2 ++
> >> 2 files changed, 17 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c
> >> index 1242cff..0d2d8d6 100644
> >> --- a/drivers/thermal/step_wise.c
> >> +++ b/drivers/thermal/step_wise.c
> >> @@ -35,6 +35,10 @@
> >> * state for this trip point
> >> * b. if the trend is THERMAL_TREND_DROPPING, use lower cooling
> >> * state for this trip point
> >> + * c. if the trend is THERMAL_TREND_RAISE_FULL, use highest cooling
> >> + * state for this trip point
> >> + * d. if the trend is THERMAL_TREND_DROP_FULL, use lowest cooling
> >> + * state for this trip point
> >> */
> >> static unsigned long get_target_state(struct thermal_instance *instance,
> >> enum thermal_trend trend)
> >> @@ -50,7 +54,10 @@ static unsigned long get_target_state(struct thermal_instance *instance,
> >> } else if (trend == THERMAL_TREND_DROPPING) {
> >> cur_state = cur_state > instance->lower ?
> >> (cur_state - 1) : instance->lower;
> >> - }
> >> + } else if (trend == THERMAL_TREND_RAISE_FULL)
> >> + cur_state = instance->upper;
> >> + else if (trend == THERMAL_TREND_DROP_FULL)
> >> + cur_state = instance->lower;
> >>
> >> return cur_state;
> >> }
> >> @@ -87,7 +94,8 @@ static void update_instance_for_throttle(struct thermal_zone_device *tz,
> >> }
> >>
> >> static void update_instance_for_dethrottle(struct thermal_zone_device *tz,
> >> - int trip, enum thermal_trip_type trip_type)
> >> + int trip, enum thermal_trip_type trip_type,
> >> + enum thermal_trend trend)
> >> {
> >> struct thermal_instance *instance;
> >> struct thermal_cooling_device *cdev;
> >> @@ -101,7 +109,10 @@ static void update_instance_for_dethrottle(struct thermal_zone_device *tz,
> >> cdev = instance->cdev;
> >> cdev->ops->get_cur_state(cdev, &cur_state);
> >>
> >> - instance->target = cur_state > instance->lower ?
> >> + if (trend == THERMAL_TREND_DROP_FULL)
> >> + instance->target = instance->lower;
> >> + else
> >> + instance->target = cur_state > instance->lower ?
> >> (cur_state - 1) : THERMAL_NO_TARGET;
> >>
> > what do you expect to happen if the trend is THERMAL_TREND_RAISE_FULL at
> > this time?
> >
> Hi Rui,
>
> I suppose this is dethrotle routine and hence this will be called when
> only drop in temperature happens. Also I did not used get_target_state
> here because I thought it might cause regression in the other existing
> thermal drivers(I am not sure) But I guess calling get_target_state is
> the good way to know next target state and is fine if you agree.
> Also one suggestion, 2 functions for throttle/dethrottle can be merged
> as both look same and just get_target_state can be used in that
> function
>
agree.
patches have been refreshed, please review.
thanks,
rui
next prev parent reply other threads:[~2012-11-22 18:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 4:26 [PATCH 0/4] thermal: Add support for interrupt based notification to thermal layer Amit Daniel Kachhap
2012-11-08 4:26 ` [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling Amit Daniel Kachhap
2012-11-08 6:01 ` Zhang Rui
2012-11-08 6:26 ` Amit Kachhap
2012-11-09 3:51 ` Zhang Rui
2012-11-09 5:54 ` R, Durgadoss
2012-11-09 6:21 ` Amit Kachhap
2012-11-12 5:42 ` Zhang Rui
2012-11-12 5:55 ` R, Durgadoss
2012-11-12 6:33 ` Zhang Rui
2012-11-12 7:31 ` R, Durgadoss
2012-11-09 5:16 ` R, Durgadoss
2012-11-22 1:22 ` Zhang Rui
2012-11-22 4:41 ` Amit Kachhap
2012-11-22 8:12 ` Zhang Rui [this message]
2012-11-23 4:05 ` Amit Kachhap
2012-11-23 6:21 ` Zhang Rui
2012-11-08 4:26 ` [PATCH 2/4] Thermal: exynos: Add support for temperature falling interrupt Amit Daniel Kachhap
2012-11-08 4:26 ` [PATCH 3/4] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt Amit Daniel Kachhap
2012-11-21 9:04 ` [PATCH 0/4] thermal: Add support for interrupt based notification to thermal layer Zhang, Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353571951.2297.7.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=amit.kachhap@linaro.org \
--cc=durgadoss.r@intel.com \
--cc=jonghwa3.lee@samsung.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).