From: Philipp Zabel <p.zabel@pengutronix.de>
To: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Shawn Guo <shawn.guo@linaro.org>,
Richard Zhao <richard.zhao@freescale.com>,
Huang Shijie <shijie8@gmail.com>,
Dong Aisheng <dong.aisheng@linaro.org>,
Matt Porter <mporter@ti.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Javier Martin <javier.martin@vista-silicon.com>,
kernel@pengutronix.de, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v7 0/4] Add generic driver for on-chip SRAM
Date: Tue, 04 Dec 2012 09:53:38 +0100 [thread overview]
Message-ID: <1354611218.3410.11.camel@pizza.hi.pengutronix.de> (raw)
In-Reply-To: <1353680655-21624-1-git-send-email-p.zabel@pengutronix.de>
Hi,
On Fri, 2012-11-23 at 15:24 +0100, Philipp Zabel wrote:
> These patches add support to configure on-chip SRAM via device-tree
> node or platform data and to obtain the resulting genalloc pool from
> the physical address or a phandle pointing at the device tree node.
> This allows drivers to allocate SRAM with the genalloc API without
> hard-coding the genalloc pool pointer.
are there any further comments on this series?
> The on-chip SRAM on i.MX53 and i.MX6q can be registered via device tree
> and changed to use the simple generic SRAM driver:
>
> ocram: ocram@00900000 {
> compatible = "fsl,imx-ocram", "sram";
> reg = <0x00900000 0x3f000>;
> };
>
> A driver that needs to allocate SRAM buffers, like the video processing
> unit on i.MX53, can retrieve the genalloc pool from a phandle in the
> device tree using of_get_named_gen_pool(node, "iram", 0) from patch 1:
>
> vpu@63ff4000 {
> /* ... */
> iram = <&ocram>;
> };
>
> The allocation granularity is hard-coded to 32 bytes for now,
> until a way to configure it can be agreed upon. There is overhead
> for bigger SRAMs, where only a much coarser allocation granularity
> is needed: At 32 bytes minimum allocation size, a 256 KiB SRAM
> needs a 1 KiB bitmap to track allocations.
>
> Once everybody is ok with it, could the first two patches be merged
> through the char-misc tree? I'll resend the i.MX and coda patches to
> the respective lists afterwards.
Arnd, Greg, would you take the first patch "genalloc: add a global pool
list, allow to find pools by phys address" into the char-misc tree if
there are no vetoes? Or should I try and get it merged separately,
first?
regards
Philipp
> Changes since v6:
> - Reduced the hard coded allocation granularity to 32 bytes.
>
> regards
> Philipp
>
> ---
> Documentation/devicetree/bindings/misc/sram.txt | 17 ++++
> arch/arm/boot/dts/imx53.dtsi | 5 +
> arch/arm/boot/dts/imx6q.dtsi | 6 ++
> drivers/media/platform/Kconfig | 3 +-
> drivers/media/platform/coda.c | 47 ++++++---
> drivers/misc/Kconfig | 9 ++
> drivers/misc/Makefile | 1 +
> drivers/misc/sram.c | 121 +++++++++++++++++++++++
> include/linux/genalloc.h | 14 +++
> lib/genalloc.c | 67 +++++++++++++
> 10 files changed, 274 insertions(+), 16 deletions(-)
next prev parent reply other threads:[~2012-12-04 8:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 14:24 [PATCH v7 0/4] Add generic driver for on-chip SRAM Philipp Zabel
2012-11-23 14:24 ` [PATCH v7 1/4] genalloc: add a global pool list, allow to find pools by phys address Philipp Zabel
2012-11-23 14:24 ` [PATCH v7 2/4] misc: Generic on-chip SRAM allocation driver Philipp Zabel
2012-11-23 14:24 ` [PATCH v7 3/4] media: coda: use genalloc API Philipp Zabel
2012-11-23 14:24 ` [PATCH v7 4/4] ARM: dts: add sram for imx53 and imx6q Philipp Zabel
2012-12-04 8:53 ` Philipp Zabel [this message]
2012-12-04 16:19 ` [PATCH v7 0/4] Add generic driver for on-chip SRAM Greg Kroah-Hartman
2012-12-04 16:55 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354611218.3410.11.camel@pizza.hi.pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dong.aisheng@linaro.org \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=javier.martin@vista-silicon.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@ti.com \
--cc=paul.gortmaker@windriver.com \
--cc=richard.zhao@freescale.com \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).