From: "Jon Medhurst (Tixy)" <tixy@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Ingo Molnar <mingo@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Rabin Vincent <rabin@rab.in>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: ftrace: Ensure code modifications are synchronised across all cpus
Date: Fri, 07 Dec 2012 17:45:47 +0000 [thread overview]
Message-ID: <1354902347.8263.12.camel@linaro1.home> (raw)
In-Reply-To: <1354900436.17101.58.camel@gandalf.local.home>
On Fri, 2012-12-07 at 12:13 -0500, Steven Rostedt wrote:
> I'll make my question more general:
>
> If I have a nop, that is a size of a call (branch and link), which is
> near the beginning of a function and not part of any conditional, and I
> want to convert it into a call (branch and link), would adding a
> breakpoint to it, modifying it to the call, and then removing the
> breakpoint be possible? Of course it would require syncing in between
> steps, but my question is, if the above is possible on a thumb2 ARM
> processor?
I believe so. The details are (repeating your earlier explanation) ...
1. Replace first half of nop with 16bit 'breakpoint' instruction.
2. Sync.(cache flush to PoU + IPIs to make other cores invalidate the
icache for changed part of the nop instruction).
3. Replace second half of nop with second half of the call instruction.
4. Sync.
5. Replace the breakpoint with the first half of the call instruction.
6. Sync
And if any core execute the breakpoint instruction, then the handler
ensures execution continues at the instruction after the nop were trying
to replace.
However, wouldn't we need any of this breakpoint malarkey, why not just
just use a 16-bit branch instruction which branches over the second half
of the nop? :-)
--
Tixy
next prev parent reply other threads:[~2012-12-07 17:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 18:11 [PATCH] ARM: ftrace: Ensure code modifications are synchronised across all cpus Jon Medhurst (Tixy)
2012-12-06 19:19 ` Steven Rostedt
2012-12-07 9:22 ` Jon Medhurst (Tixy)
2012-12-07 14:03 ` Steven Rostedt
2012-12-07 14:55 ` Jon Medhurst (Tixy)
2012-12-07 15:28 ` Steven Rostedt
2012-12-07 15:40 ` Jon Medhurst (Tixy)
2012-12-07 16:09 ` Steven Rostedt
2012-12-07 16:23 ` Russell King - ARM Linux
2012-12-07 16:36 ` Steven Rostedt
2012-12-07 16:45 ` Russell King - ARM Linux
2012-12-07 17:13 ` Steven Rostedt
2012-12-07 17:45 ` Jon Medhurst (Tixy) [this message]
2012-12-07 18:06 ` Steven Rostedt
2012-12-07 18:17 ` Steven Rostedt
2012-12-07 18:18 ` Jon Medhurst (Tixy)
2012-12-10 10:04 ` Will Deacon
2012-12-10 13:02 ` Steven Rostedt
2012-12-10 13:33 ` Will Deacon
2012-12-10 13:40 ` Jamie Lokier
2012-12-10 14:56 ` Will Deacon
2012-12-10 13:57 ` Russell King - ARM Linux
2012-12-10 14:06 ` Steven Rostedt
2012-12-10 14:07 ` Russell King - ARM Linux
2012-12-10 14:46 ` Steven Rostedt
2012-12-10 15:25 ` Russell King - ARM Linux
2012-12-10 16:31 ` Steven Rostedt
2012-12-10 16:45 ` Jon Medhurst (Tixy)
2012-12-07 18:13 ` Russell King - ARM Linux
2012-12-07 18:43 ` Steven Rostedt
2012-12-07 19:02 ` Will Deacon
2012-12-07 20:01 ` Steven Rostedt
2012-12-10 11:04 ` Jon Medhurst (Tixy)
2012-12-10 11:24 ` Will Deacon
2012-12-10 14:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354902347.8263.12.camel@linaro1.home \
--to=tixy@linaro.org \
--cc=fweisbec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=rabin@rab.in \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).