From: Stefani Seibold <stefani@seibold.net>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
mingo@redhat.com, ak@linux.intel.com, aarcange@redhat.com,
john.stultz@linaro.org, luto@amacapital.net
Subject: Re: [PATCH] Add VDSO time function support for x86 32-bit kernel
Date: Thu, 13 Dec 2012 06:53:25 +0100 [thread overview]
Message-ID: <1355378005.24283.11.camel@wall-e> (raw)
In-Reply-To: <50C9148C.4040308@zytor.com>
Am Mittwoch, den 12.12.2012, 15:34 -0800 schrieb H. Peter Anvin:
> On 12/12/2012 12:19 PM, stefani@seibold.net wrote:
> > diff --git a/arch/x86/vdso/vdso32/vclock_gettime.c b/arch/x86/vdso/vdso32/vclock_gettime.c
> > new file mode 100644
> > index 0000000..c9a1909
> > --- /dev/null
> > +++ b/arch/x86/vdso/vdso32/vclock_gettime.c
> > @@ -0,0 +1,7 @@
> > +/*
> > + * since vgtod layout differs between X86_64 and x86_32, it is not possible to
> > + * provide a 32 bit vclock with a 64 bit kernel
> > + */
> > +#ifdef CONFIG_X86_32
> > +#include "../vclock_gettime.c"
> > +#endif
>
> This is where this goes fail. Sorry, it is not acceptable to introduce
> an ABI on x86-32 without providing it also on x86-64 in compatibility mode.
>
> I also don't believe it is not possible... it might require some more
> cleverness; perhaps we need to do the 32-bit vgtod in such a way that it
> *is* compatible with 64 bits.
>
The comment is ambiguous:
Since vgtod layout differs between X86_64 and x86_32 AND the vgtod is
not inside the accessible address space of a 32 bit program, it is
CURRENTLY not possible to provide a 32 bit vclock with a 64 bit kernel
As i understand VDSO it is an alternativ way, so if there is no support
for it, there must be a fall back to the system call interface in the
program or lib, which tries to use it.
So there is no drawback for 32 bit programs running on a 64 bit kernel.
I think this feature is not so important and can implemented in a
subsequent patch, because a 64 bit kernel system mostly runs 64 bit
programs. Let us fix this things step by step.
- Stefani
next prev parent reply other threads:[~2012-12-13 5:54 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 20:19 [PATCH] Add VDSO time function support for x86 32-bit kernel stefani
2012-12-12 23:34 ` H. Peter Anvin
2012-12-13 5:53 ` Stefani Seibold [this message]
2012-12-13 6:10 ` H. Peter Anvin
2012-12-13 6:14 ` H. Peter Anvin
2012-12-13 6:17 ` Stefani Seibold
2012-12-13 6:47 ` H. Peter Anvin
2012-12-13 7:17 ` Stefani Seibold
2012-12-13 19:32 ` Andy Lutomirski
2012-12-14 0:09 ` H. Peter Anvin
2012-12-14 0:20 ` Andy Lutomirski
2012-12-14 0:36 ` H. Peter Anvin
2012-12-14 1:32 ` H. Peter Anvin
2012-12-14 1:42 ` Andy Lutomirski
2012-12-14 1:49 ` H. Peter Anvin
2012-12-14 2:11 ` Andy Lutomirski
2012-12-14 2:18 ` H. Peter Anvin
2012-12-14 2:20 ` Andy Lutomirski
2012-12-14 8:34 ` [CRIU] " Pavel Emelyanov
2012-12-14 18:35 ` H. Peter Anvin
2012-12-14 18:44 ` Andy Lutomirski
2012-12-14 18:47 ` H. Peter Anvin
2012-12-14 20:12 ` Cyrill Gorcunov
2012-12-14 21:08 ` H. Peter Anvin
2012-12-14 21:20 ` Cyrill Gorcunov
2012-12-14 21:21 ` H. Peter Anvin
2012-12-14 21:27 ` Andy Lutomirski
2012-12-14 22:00 ` H. Peter Anvin
2012-12-14 22:25 ` Cyrill Gorcunov
2012-12-14 22:27 ` H. Peter Anvin
2012-12-14 22:43 ` Cyrill Gorcunov
2012-12-14 22:48 ` H. Peter Anvin
2012-12-14 23:48 ` John Stultz
2012-12-14 23:55 ` H. Peter Anvin
2012-12-17 9:05 ` Pavel Emelyanov
[not found] ` <fb2e871b-3e2a-4e96-9eb9-cb2dd4f66eaa@email.android! .com>
2012-12-17 15:21 ` H. Peter Anvin
2012-12-17 18:56 ` Pavel Emelyanov
2012-12-17 18:57 ` H. Peter Anvin
2012-12-14 22:46 ` H. Peter Anvin
2012-12-14 23:09 ` Stefani Seibold
2012-12-14 23:29 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2012-12-11 16:11 stefani
2012-12-11 19:27 ` John Stultz
2012-12-11 19:37 ` Andy Lutomirski
2012-12-11 20:54 ` Stefani Seibold
2012-12-11 21:18 ` Andy Lutomirski
2012-12-11 21:28 ` Stefani Seibold
2012-12-11 19:37 ` Andy Lutomirski
2012-12-11 20:40 ` Stefani Seibold
2012-12-12 1:29 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355378005.24283.11.camel@wall-e \
--to=stefani@seibold.net \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).