Re: [tip] config: Add 'make kvmconfig'

[David Woodhouse <dwmw2@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On Tue, 2012-12-25 at 22:32 -0800, David Rientjes wrote:
> 
> This creates quite a few build failures on auto-latest:
> 
> arch/x86/built-in.o: In function `hpet_setup_msi_irq':
> hpet.c:(.text+0x34638): undefined reference to `arch_setup_hpet_msi'
> hpet.c:(.text+0x34651): undefined reference to `destroy_irq'
> arch/x86/built-in.o: In function `hpet_msi_capability_lookup':
> hpet.c:(.text+0x347ff): undefined reference to `create_irq_nr'
> arch/x86/built-in.o:(.data+0xd1c): undefined reference to `native_setup_msi_irqs'
> arch/x86/built-in.o:(.data+0xd20): undefined reference to `native_teardown_msi_irq'

This one is actually caused by commit 3b08ed026 (config: Add 'make
kvmconfig'), which selects PCI_MSI even on a 32-bit config where it's
invalid to do so.

Ew, that commit seems like a *completely* wrong-headed idea. That abuse
of 'select' is just begging for this kind of breakage. We have other
ways to merge configs and turn certain options on, without doing it this
way.

-- 
dwmw2


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]