From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A7FECAAA1 for ; Fri, 9 Sep 2022 15:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229876AbiIIPLJ (ORCPT ); Fri, 9 Sep 2022 11:11:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232138AbiIIPLC (ORCPT ); Fri, 9 Sep 2022 11:11:02 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0322EE984; Fri, 9 Sep 2022 08:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662736260; x=1694272260; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vGy4fIFwjFSNzA65qv4QDCYsy+swZzfD5tvaJcOb5X4=; b=maglAEPBCMFqi8C/cflgtKDpV2ASrc1p2Ui21rpg+cpNTeU4DHUrmCuV 1RiybquVl3mCHYi5VNJFP7wRqL3RosMkboX0MnjApyQkAxkdfbUMMBAj7 e6MfEdJ/8pQu6c8+oV7vWRIaggJdSTi2b/Q6jT0k6V12/vOF2V7DRklBa LAga3kgWGgMzFW7M/BBwAqOBD5JO5MT1vAS3XKupikCn+bKbEwdZ3K0CJ bUbSJHeShnH0YfMOAHVOcH6wTZX7/TNEcDPYXVLwLyYrJRm49Rz98BQA0 +ZSbjsINIisT/JYC3tTioHrNyKIlyZCmBCUFHKftrpKhnmW9pBk4duokw Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10465"; a="359217074" X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="359217074" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 08:10:59 -0700 X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="611085785" Received: from jkrzyszt-mobl1.ger.corp.intel.com ([10.213.25.143]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 08:10:54 -0700 From: Janusz Krzysztofik To: igt-dev@lists.freedesktop.org Cc: linux-kselftest@vger.kernel.org, daniel@ffwll.ch, kunit-dev@googlegroups.com, magalilemes00@gmail.com, maira.canal@usp.br, dlatypov@google.com, n@nfraprado.net, linux-kernel@vger.kernel.org, leandro.ribeiro@collabora.com, dri-devel@lists.freedesktop.org, davidgow@google.com, tales.aparecida@gmail.com, skhan@linuxfoundation.org, andrealmeid@riseup.net, Isabella Basso , brendanhiggins@google.com, twoerner@gmail.com, Isabella Basso Subject: Re: [igt-dev] [PATCH i-g-t v2 2/4] lib/igt_kmod.c: check if module is builtin before attempting to unload it Date: Fri, 09 Sep 2022 17:10:52 +0200 Message-ID: <13576898.RDIVbhacDa@jkrzyszt-mobl1.ger.corp.intel.com> Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20220829000920.38185-3-isabbasso@riseup.net> References: <20220829000920.38185-1-isabbasso@riseup.net> <20220829000920.38185-3-isabbasso@riseup.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, 29 August 2022 02:09:18 CEST Isabella Basso wrote: > This change makes `igt_module_unload_r` safer as it checks whether the s/igt_module_unload_r/igt_kmod_unload_r/ > module can be unloaded before attempting it. > > Signed-off-by: Isabella Basso > --- > lib/igt_kmod.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c > index bb6cb7bb..97cac7f5 100644 > --- a/lib/igt_kmod.c > +++ b/lib/igt_kmod.c > @@ -256,6 +256,9 @@ static int igt_kmod_unload_r(struct kmod_module *kmod, unsigned int flags) > struct kmod_list *holders, *pos; > int err = 0; > > + if (kmod_module_get_initstate(kmod) == KMOD_MODULE_BUILTIN) > + return err; NIT: I think that return 0; would be more clear. Anyway, Acked-by: Janusz Krzysztofik > + > holders = kmod_module_get_holders(kmod); > kmod_list_foreach(pos, holders) { > struct kmod_module *it = kmod_module_get_module(pos); >