linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Ding <dinggnu@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Kusanagi Kouichi <slash@ac.auone-net.jp>,
	Jarkko Sakkinen <jarkko.sakkinen@intel.com>,
	Jiri Kosina <jkosina@suse.cz>,
	Matt Fleming <matt.fleming@intel.com>,
	linux-kernel@vger.kernel.org
Cc: Cong Ding <dinggnu@gmail.com>
Subject: [PATCH] x86: tools/relocs.c: fix resource leakage
Date: Mon, 14 Jan 2013 17:13:35 +0000	[thread overview]
Message-ID: <1358183628-27784-1-git-send-email-dinggnu@gmail.com> (raw)

the opened file should be closed.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 arch/x86/tools/relocs.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
index 5a1847d..79d67bd 100644
--- a/arch/x86/tools/relocs.c
+++ b/arch/x86/tools/relocs.c
@@ -814,12 +814,14 @@ int main(int argc, char **argv)
 	read_relocs(fp);
 	if (show_absolute_syms) {
 		print_absolute_symbols();
-		return 0;
+		goto out;
 	}
 	if (show_absolute_relocs) {
 		print_absolute_relocs();
-		return 0;
+		goto out;
 	}
 	emit_relocs(as_text, use_real_mode);
+out:
+	fclose(fp);
 	return 0;
 }
-- 
1.7.9.5


             reply	other threads:[~2013-01-14 17:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 17:13 Cong Ding [this message]
2013-01-24 20:09 ` [tip:x86/boot] x86/boot: Fix minor fd leakage in tools/relocs.c tip-bot for Cong Ding
2013-01-28  0:06 ` tip-bot for Cong Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358183628-27784-1-git-send-email-dinggnu@gmail.com \
    --to=dinggnu@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jarkko.sakkinen@intel.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@redhat.com \
    --cc=slash@ac.auone-net.jp \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).