From: Laxman Dewangan <ldewangan@nvidia.com>
To: <sameo@linux.intel.com>
Cc: <grant.likely@secretlab.ca>, <rob.herring@calxeda.com>,
<broonie@opensource.wolfsonmicro.com>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: [PATCH RESEND 4/4] mfd: tps65090: remove suspend/resume callbacks
Date: Sun, 27 Jan 2013 14:27:15 +0530 [thread overview]
Message-ID: <1359277035-16854-5-git-send-email-ldewangan@nvidia.com> (raw)
In-Reply-To: <1359277035-16854-1-git-send-email-ldewangan@nvidia.com>
The tps65090 mfd driver implement the suspend/resume callbacks
which just disable and enable irqs in suspend/resume respectively.
This operation is already done in irq suspend and irq_resume and
hence it is not require to implement the same in the driver.
Remove this non-require code.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
This change is based on Mark Brown's comment when reviewing tps80031 mfd driver
as we do not need suspend/resume just for disabling/enabling interrupts.
Resending the patch wth Mark Acks.
drivers/mfd/tps65090.c | 23 -----------------------
1 files changed, 0 insertions(+), 23 deletions(-)
diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
index 3e987be..995e7b3 100644
--- a/drivers/mfd/tps65090.c
+++ b/drivers/mfd/tps65090.c
@@ -262,28 +262,6 @@ static int tps65090_i2c_remove(struct i2c_client *client)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
-static int tps65090_suspend(struct device *dev)
-{
- struct i2c_client *client = to_i2c_client(dev);
- if (client->irq)
- disable_irq(client->irq);
- return 0;
-}
-
-static int tps65090_resume(struct device *dev)
-{
- struct i2c_client *client = to_i2c_client(dev);
- if (client->irq)
- enable_irq(client->irq);
- return 0;
-}
-#endif
-
-static const struct dev_pm_ops tps65090_pm_ops = {
- SET_SYSTEM_SLEEP_PM_OPS(tps65090_suspend, tps65090_resume)
-};
-
static const struct i2c_device_id tps65090_id_table[] = {
{ "tps65090", 0 },
{ },
@@ -295,7 +273,6 @@ static struct i2c_driver tps65090_driver = {
.name = "tps65090",
.owner = THIS_MODULE,
.of_match_table = of_match_ptr(tps65090_of_match),
- .pm = &tps65090_pm_ops,
},
.probe = tps65090_i2c_probe,
.remove = tps65090_i2c_remove,
--
1.7.1.1
prev parent reply other threads:[~2013-01-27 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 8:57 [PATCH RESEND 0/4] mfd/regulator: tps65090: add DT support and suspend/resume cleanups Laxman Dewangan
2013-01-27 8:57 ` [PATCH RESEND 1/4] mfd: tps65090: add DT support for tps65090 Laxman Dewangan
2013-01-28 15:52 ` Stephen Warren
2013-01-27 8:57 ` [PATCH RESEND 2/4] regulator: tps65090: add DT support Laxman Dewangan
2013-01-28 15:58 ` Stephen Warren
2013-01-27 8:57 ` [PATCH RESEND 3/4] mfd: tps65090: Pass irq domain when adding mfd sub devices Laxman Dewangan
2013-01-27 8:57 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359277035-16854-5-git-send-email-ldewangan@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).