linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-arch@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/9] Provide dma_mmap_coherent() and dma_get_sgtable()
Date: Sun, 27 Jan 2013 11:33:19 +0100	[thread overview]
Message-ID: <1359282808-31398-1-git-send-email-geert@linux-m68k.org> (raw)

dma_common_mmap() and dma_common_get_sgtable() are defined in
drivers/base/dma-mapping.c, and always compiled if CONFIG_HAS_DMA=y.

However, their forward declarations and the inline functions defined on top
of them (dma_mmap_attrs(), dma_mmap_coherent(), dma_mmap_writecombine(),
dma_get_sgtable_attrs()), dma_get_sgtable()) are in
<asm-generic/dma-mapping-common.h>, which is not included by all
architectures supporting CONFIG_HAS_DMA=y.  There exist no alternative
implementations.

Hence for e.g. m68k allmodconfig, I get:

drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:204: error: implicit declaration of function ‘dma_mmap_coherent’
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:387: error: implicit declaration of function ‘dma_get_sgtable’

This series adds dma_mmap_coherent() and dma_get_sgtable() for all
architectures that set CONFIG_HAS_DMA=y, but don't use dma_map_ops.

  - On architectures for which I received an ack (avr32, blackfin, cris,
    and m68k), the patches are unchanged compared to v1: dma_mmap_coherent()
    and dma_get_sgtable() are implement as inline stubs using
    dma_common_mmap() and dma_common_get_sgtable().

  - On architectures where the current API cannot be implemented (parisc),
    dma_mmap_coherent() and dma_get_sgtable() are dummy implementations that
    just return -EINVAL, until the API has been finalized.

  - On architectures for which I did not receive an ack (c6x, frv, mn10300,
    and xtensa), dma_mmap_coherent() and dma_get_sgtable() are dummy
    implementations that just return -EINVAL, too.

I'll add this to the m68k for-next branch, so hopefully we can get an
unbroken build in 3.8.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2013-01-27 10:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-27 10:33 Geert Uytterhoeven [this message]
2013-01-27 10:33 ` [PATCH v2 1/9] avr32: Provide dma_mmap_coherent() and dma_get_sgtable() Geert Uytterhoeven
2013-01-27 10:33 ` [PATCH v2 2/9] blackfin: " Geert Uytterhoeven
2013-01-28  9:08   ` [uclinux-dist-devel] " Bob Liu
2013-01-27 10:33 ` [PATCH v2 3/9] c6x: Provide dummy " Geert Uytterhoeven
2013-01-27 10:33 ` [PATCH v2 4/9] cris: Provide " Geert Uytterhoeven
2013-01-27 10:33 ` [PATCH v2 5/9] frv: Provide dummy " Geert Uytterhoeven
2013-01-27 10:33 ` [PATCH v2 6/9] m68k: Provide " Geert Uytterhoeven
2013-01-27 10:33 ` [PATCH v2 7/9] mn10300: Provide dummy " Geert Uytterhoeven
2013-01-27 10:33 ` [PATCH v2 8/9] parisc: " Geert Uytterhoeven
2013-01-27 10:33 ` [PATCH v2 9/9] xtensa: " Geert Uytterhoeven
2013-01-27 10:43 ` [PATCH v2 0/9] Provide " Geert Uytterhoeven
2013-01-28  8:09   ` Marek Szyprowski
2013-01-28  8:20     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359282808-31398-1-git-send-email-geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).