From: anish kumar <anish198519851985@gmail.com>
To: Don Zickus <dzickus@redhat.com>
Cc: Mike Lykov <combr@yandex.ru>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
kirill@shutemov.name
Subject: Re: [BUG?] false positive in soft lockup detector while unlzma initramfs on slow cpu
Date: Wed, 30 Jan 2013 21:29:12 +0530 [thread overview]
Message-ID: <1359561552.1641.218.camel@anish-Inspiron-N5050> (raw)
In-Reply-To: <20130130155121.GF98867@redhat.com>
On Wed, 2013-01-30 at 10:51 -0500, Don Zickus wrote:
> On Tue, Jan 29, 2013 at 10:48:27PM +0530, anish kumar wrote:
> > Sorry for digressing from the topic but I think there is something wrong
> > with my understanding or something wrong with the code.So I guess Don
> > can clarify this.
> > If I pass this below parameter during boot i.e. setting watchdog_enabled
> > to zero.
> > __setup("nowatchdog", nowatchdog_setup);
> >
> > Now I use sysctl to enable the watchdog then wouldn't the below code
> > will hinder enabling the watchdog?
> >
> > static void watchdog_enable_all_cpus(void)
> > {//snip
> > if (watchdog_disabled) { /* this is zero ?? */
> > watchdog_disabled = 0;
> > //snip
> > }
> >
> > Should watchdog_disabled be set to 1?Or is it that we always disable the
> > watchdog and then enable it?
>
> It seems like a bug, so does something like this fix it? There is
> probably a better way to handle the internal representation of the
> watchdog state (watchdog_disable) and the procfs version
> (watchdog_enable), but I just can't think of something right now. :-(
>
> Cheers,
> Don
>
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 75a2ab3..d287726 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -82,6 +82,7 @@ __setup("softlockup_panic=", softlockup_panic_setup);
> static int __init nowatchdog_setup(char *str)
> {
> watchdog_enabled = 0;
> + watchdog_disabled =1;
I don't know if this will work or not but while going through the code I
spotted this.I will think of something better if I couldn't think of
anything better than anyway we have this patch.
> return 1;
> }
> __setup("nowatchdog", nowatchdog_setup);
next prev parent reply other threads:[~2013-01-30 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 13:42 [BUG?] false positive in soft lockup detector while unlzma initramfs on slow cpu Mike Lykov
2013-01-29 15:33 ` Don Zickus
2013-01-29 17:18 ` anish kumar
2013-01-30 15:51 ` Don Zickus
2013-01-30 15:59 ` anish kumar [this message]
2013-01-29 23:59 ` Andrew Morton
2013-01-31 11:18 ` Ingo Molnar
2013-01-30 9:39 ` Mike Lykov
2013-01-30 15:40 ` Don Zickus
2013-01-31 11:21 ` Mike Lykov
2013-01-31 14:46 ` Don Zickus
2013-02-01 10:44 ` Mike Lykov
2013-02-01 15:59 ` Don Zickus
2013-02-01 16:43 ` Mike Lykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359561552.1641.218.camel@anish-Inspiron-N5050 \
--to=anish198519851985@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=combr@yandex.ru \
--cc=dzickus@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).