From: Michel Lespinasse <walken@google.com>
To: Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] fixes for large mm_populate() and munlock() operations
Date: Wed, 30 Jan 2013 16:26:17 -0800 [thread overview]
Message-ID: <1359591980-29542-1-git-send-email-walken@google.com> (raw)
These 3 changes are to improve the handling of large mm_populate and
munlock operations. They apply on top of mmotm (in particular, they
depend on both my prior mm_populate work and Kirill's "thp: avoid
dumping huge zero page" change).
- Patch 1 fixes an integer overflow issue when populating 2^32 pages.
The nr_pages argument to get_user_pages would overflow, resulting in 0
pages being processed per iteration. I am proposing to simply convert
the nr_pages argument to a long.
- Patch 2 accelerates populating regions with THP pages. get_user_pages()
can increment the address by a huge page size in this case instead of
a small page size, and avoid repeated mm->page_table_lock acquisitions.
This fixes an issue reported by Roman Dubtsov where populating regions
via mmap MAP_POPULATE was significantly slower than doing so by
touching pages from userspace.
- Patch 3 is a similar acceleration for the munlock case. I would actually
like to get Andrea's attention on this one, as I can't explain how
munlock_vma_page() is safe against racing with split_huge_page().
Note that patches 1-2 are logically independent of patch 3, so if the
discussion of patch 3 takes too long I would ask Andrew to consider
merging patches 1-2 first.
Michel Lespinasse (3):
mm: use long type for page counts in mm_populate() and get_user_pages()
mm: accelerate mm_populate() treatment of THP pages
mm: accelerate munlock() treatment of THP pages
arch/ia64/xen/xencomm.c | 3 ++-
arch/powerpc/kernel/vdso.c | 9 +++++----
arch/s390/mm/pgtable.c | 3 ++-
include/linux/hugetlb.h | 6 +++---
include/linux/mm.h | 16 ++++++++--------
mm/hugetlb.c | 10 +++++-----
mm/internal.h | 2 +-
mm/ksm.c | 10 +++++++---
mm/memory.c | 39 ++++++++++++++++++++++++++-------------
mm/migrate.c | 7 +++++--
mm/mlock.c | 37 ++++++++++++++++++++++++-------------
11 files changed, 88 insertions(+), 54 deletions(-)
--
1.8.1
next reply other threads:[~2013-01-31 0:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 0:26 Michel Lespinasse [this message]
2013-01-31 0:26 ` [PATCH 1/3] mm: use long type for page counts in mm_populate() and get_user_pages() Michel Lespinasse
2013-01-31 0:42 ` Andrew Morton
2013-02-07 0:39 ` Sasha Levin
2013-02-07 1:10 ` Andrew Morton
2013-02-07 1:16 ` Sasha Levin
2013-02-07 21:35 ` Michel Lespinasse
2013-01-31 0:26 ` [PATCH 2/3] mm: accelerate mm_populate() treatment of THP pages Michel Lespinasse
2013-01-31 3:05 ` Hugh Dickins
2013-01-31 4:27 ` Michel Lespinasse
2013-02-02 0:08 ` Andrew Morton
2013-01-31 0:26 ` [RFC PATCH 3/3] mm: accelerate munlock() " Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359591980-29542-1-git-send-email-walken@google.com \
--to=walken@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).