From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "dbasehore ." <dbasehore@chromium.org>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/2] don't wait on disk to start on resume
Date: Fri, 01 Feb 2013 09:27:37 +1100 [thread overview]
Message-ID: <1359671257.7527.4.camel@dabdike> (raw)
In-Reply-To: <CAGAzgso4cJHM+CNV0nCu6zUmq=xUstbsguynUp+hyx581LcHJg@mail.gmail.com>
On Thu, 2013-01-31 at 14:00 -0800, dbasehore . wrote:
> (Resending as plain text so the message is tracked on vger)
>
> Hi, thanks for reading through my patch.
>
> With regards to SCSI_SENSE_BUFFERSIZE, I'm following the precedent of
> scsi_execute_req found in drivers/scsi/scsi_lib.c
I have no context for this: I don't recall making any comment on sense
buffers; what are you replying to?
James
> It seems that it is used by the scsi_normalize_sense function which I
> call in sd_resume_async. I just input SCSI_SENSE_BUFFERSIZE directly
> there though. I didn't know if anything would change its behavior on a
> lower level if I made sense_len = SCSI_SENSE_BUFFERSIZE, so I just
> went with what was already done.
>
> I'll make sure the semantic fixes go into the final patch.
>
> Also, I forgot to mention one possible problem earlier. I understand
> that some hard drives have a command buffer that can be executed by
> the hard drive in an order it determines. Does anyone know of a
> potential problem if the following happens?
>
> -resume finishes (hard drive not started yet)
> -read/write sent to disk, inserted before start command
>
> Could this happen? If so, could it cause any problems?
>
> I've tested the possibility of a program trying to read/write from the
> disk before it has started, and the read/write blocks until the disk
> has actually been spun up. I don't know if there are specific hard
> drives where this could be a problem though.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-31 22:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 4:35 [PATCH 1/2] don't wait on disk to start on resume Derek Basehore
2012-12-21 4:35 ` [PATCH 2/2] ata: don't wait " Derek Basehore
2012-12-22 14:32 ` [PATCH 1/2] don't wait on disk to start " Sergei Shtylyov
2013-01-31 22:00 ` dbasehore .
2013-01-31 22:27 ` James Bottomley [this message]
2013-01-31 22:32 ` dbasehore .
2012-12-23 11:49 ` James Bottomley
2013-01-31 22:02 ` dbasehore .
2013-01-31 22:26 ` James Bottomley
2013-02-01 11:51 ` Aaron Lu
2013-02-01 15:28 ` Alan Stern
2013-02-02 10:45 ` Aaron Lu
2013-02-02 15:09 ` Alan Stern
2013-02-03 6:23 ` Aaron Lu
2013-02-04 0:07 ` dbasehore .
2013-02-04 14:27 ` Aaron Lu
2013-02-04 8:04 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359671257.7527.4.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=dbasehore@chromium.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).